This is an archive of the discontinued LLVM Phabricator instance.

Differential D51684

[mips] Correct MUL pattern for mips64
ClosedPublic

Authored by smaksimovic on Sep 5 2018, 7:30 AM.

Details

Reviewers
atanasyan
Commits
rG9a20188b021e: Merging r342946:
rG90e7ff804508: [mips] Correct MUL pattern for mips64
rL346742: Merging r342946:
rL342946: [mips] Correct MUL pattern for mips64
Summary

Guard existing pattern with a predicate, introduce a new one for revision 6.

Diff Detail

Repository
rL LLVM

Event Timeline

smaksimovic created this revision.Sep 5 2018, 7:30 AM
Herald added subscribers: arichardson, sdardis. · View Herald TranscriptSep 5 2018, 7:30 AM
atanasyan accepted this revision.Sep 8 2018, 10:33 PM

LGTM

This revision is now accepted and ready to land.Sep 8 2018, 10:33 PM
Closed by commit rL342946: [mips] Correct MUL pattern for mips64 (authored by smaksimovic). · Explain WhySep 24 2018, 11:29 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: jrtc27. · View Herald TranscriptSep 24 2018, 11:29 PM

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
Mips/
2 lines
3 lines

Diff 166815

llvm/trunk/lib/Target/Mips/Mips64InstrInfo.td

Show First 20 Lines • Show All 832 Lines • ▼ Show 20 Lines
def : MipsPat<(i64 (sext (i32 (add GPR32:$src, GPR32:$src2)))), def : MipsPat<(i64 (sext (i32 (add GPR32:$src, GPR32:$src2)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(ADDu GPR32:$src, GPR32:$src2), sub_32)>; (ADDu GPR32:$src, GPR32:$src2), sub_32)>;
def : MipsPat<(i64 (sext (i32 (sub GPR32:$src, GPR32:$src2)))), def : MipsPat<(i64 (sext (i32 (sub GPR32:$src, GPR32:$src2)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(SUBu GPR32:$src, GPR32:$src2), sub_32)>; (SUBu GPR32:$src, GPR32:$src2), sub_32)>;
def : MipsPat<(i64 (sext (i32 (mul GPR32:$src, GPR32:$src2)))), def : MipsPat<(i64 (sext (i32 (mul GPR32:$src, GPR32:$src2)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(MUL GPR32:$src, GPR32:$src2), sub_32)>; (MUL GPR32:$src, GPR32:$src2), sub_32)>, ISA_MIPS3_NOT_32R6_64R6;
def : MipsPat<(i64 (sext (i32 (MipsMFHI ACC64:$src)))), def : MipsPat<(i64 (sext (i32 (MipsMFHI ACC64:$src)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(PseudoMFHI ACC64:$src), sub_32)>; (PseudoMFHI ACC64:$src), sub_32)>;
def : MipsPat<(i64 (sext (i32 (MipsMFLO ACC64:$src)))), def : MipsPat<(i64 (sext (i32 (MipsMFLO ACC64:$src)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(PseudoMFLO ACC64:$src), sub_32)>; (PseudoMFLO ACC64:$src), sub_32)>;
def : MipsPat<(i64 (sext (i32 (shl GPR32:$src, immZExt5:$imm5)))), def : MipsPat<(i64 (sext (i32 (shl GPR32:$src, immZExt5:$imm5)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
▲ Show 20 Lines • Show All 295 Lines • Show Last 20 Lines

llvm/trunk/lib/Target/Mips/Mips64r6InstrInfo.td

Show First 20 Lines • Show All 295 Lines • ▼ Show 20 Linesdef : MipsPat<(select (i32 (setne i32:$cond, immz)), immz, i64:$f),
(SELEQZ64 i64:$f, (SLL64_32 i32:$cond))>, (SELEQZ64 i64:$f, (SLL64_32 i32:$cond))>,
ISA_MIPS64R6; ISA_MIPS64R6;
def : MipsPat<(select (i32 (seteq i32:$cond, immz)), immz, i64:$f), def : MipsPat<(select (i32 (seteq i32:$cond, immz)), immz, i64:$f),
(SELNEZ64 i64:$f, (SLL64_32 i32:$cond))>, (SELNEZ64 i64:$f, (SLL64_32 i32:$cond))>,
ISA_MIPS64R6; ISA_MIPS64R6;
// Patterns used for matching away redundant sign extensions. // Patterns used for matching away redundant sign extensions.
// MIPS32 arithmetic instructions sign extend their result implicitly. // MIPS32 arithmetic instructions sign extend their result implicitly.
def : MipsPat<(i64 (sext (i32 (mul GPR32:$src, GPR32:$src2)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(MUL_R6 GPR32:$src, GPR32:$src2), sub_32)>, ISA_MIPS64R6;
def : MipsPat<(i64 (sext (i32 (sdiv GPR32:$src, GPR32:$src2)))), def : MipsPat<(i64 (sext (i32 (sdiv GPR32:$src, GPR32:$src2)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(DIV GPR32:$src, GPR32:$src2), sub_32)>, ISA_MIPS64R6; (DIV GPR32:$src, GPR32:$src2), sub_32)>, ISA_MIPS64R6;
def : MipsPat<(i64 (sext (i32 (udiv GPR32:$src, GPR32:$src2)))), def : MipsPat<(i64 (sext (i32 (udiv GPR32:$src, GPR32:$src2)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
(DIVU GPR32:$src, GPR32:$src2), sub_32)>, ISA_MIPS64R6; (DIVU GPR32:$src, GPR32:$src2), sub_32)>, ISA_MIPS64R6;
def : MipsPat<(i64 (sext (i32 (srem GPR32:$src, GPR32:$src2)))), def : MipsPat<(i64 (sext (i32 (srem GPR32:$src, GPR32:$src2)))),
(INSERT_SUBREG (i64 (IMPLICIT_DEF)), (INSERT_SUBREG (i64 (IMPLICIT_DEF)),
Show All 23 Lines