Page MenuHomePhabricator

[CMake] Remove variable reference that isn't used.
ClosedPublic

Authored by cdavis5x on Sep 4 2018, 9:54 AM.

Details

Summary

This variable is never defined, so its value is always empty. Since
libunwind is needed to build the C++ ABI library in the first place,
it should never be linked to the C++ ABI library anyway.

Diff Detail

Repository
rL LLVM

Event Timeline

cdavis5x created this revision.Sep 4 2018, 9:54 AM
mstorsjo added inline comments.Sep 4 2018, 10:03 AM
src/CMakeLists.txt
54 ↗(On Diff #163855)

Is there any point in this line at all now, or can it be removed altogether?

cdavis5x added inline comments.Sep 4 2018, 10:07 AM
src/CMakeLists.txt
54 ↗(On Diff #163855)

I think list(APPEND) can fail if the variable doesn't exist.

mstorsjo accepted this revision.Sep 4 2018, 10:29 AM
mstorsjo added inline comments.
src/CMakeLists.txt
54 ↗(On Diff #163855)

Okay - after reading the cmake docs, I agree that this seems to be the correct solution.

This revision is now accepted and ready to land.Sep 4 2018, 10:29 AM
This revision was automatically updated to reflect the committed changes.