Terminate debugger if an assert was hit

[JDevlieghere]

source/Utility/LLDBAssert.cpp

21–22

I guess while we're at it we can turn this into an early return and use LLVM_LIKELY?

if (LLVM_LIKELY(expression))
    return;

[xbolva00]

source/Utility/LLDBAssert.cpp

21–22

I thought about it also.. :) I will update the patch.

[xbolva00]

• Use early return

[lemo]

source/Utility/LLDBAssert.cpp

31

abort() may be a better choice here (exit() path calls a lot of shutdown code and it's not safe in a number of cases)

[clayborg]

Yes abort is better as exit will cause the global C++ destructor chain to be called. I was always thinking lldbassert() was aborting, but seeing as this is not the case this could cause problems if you enable it as it will be a change. Watch the buildbots carefully.

[xbolva00]

• Use abort

[JDevlieghere]

LGTM

[xbolva00]

Thanks for review, commited as rL341387

[clayborg]

In D51604#1223451, @xbolva00 wrote:

Thanks for review, commited as rL341387

If you include the text:

Differential Revision: https://reviews.llvm.org/D51604

It will automatically close this and put in a comment with the revision

[xbolva00]

In D51604#1223455, @clayborg wrote:

In D51604#1223451, @xbolva00 wrote:

Thanks for review, commited as rL341387

If you include the text:

Differential Revision: https://reviews.llvm.org/D51604

It will automatically close this and put in a comment with the revision

Ok, I hope it would be okay next time.

source/Utility/LLDBAssert.cpp

 #include "llvm/Support/Signals.h"
 #include "llvm/Support/raw_ostream.h"
 
 using namespace llvm;
 using namespace lldb_private;
 
 void lldb_private::lldb_assert(bool expression, const char *expr_text,
                                const char *func, const char *file,
                                unsigned int line) {
-  if (expression)
-    ;
-  else {
-    errs() << format("Assertion failed: (%s), function %s, file %s, line %u\n",
-                     expr_text, func, file, line);
-    errs() << "backtrace leading to the failure:\n";
-    llvm::sys::PrintStackTrace(errs());
-    errs() << "please file a bug report against lldb reporting this failure "
-              "log, and as many details as possible\n";
-  }
+  if (LLVM_LIKELY(expression))
+    return;
+
+  abort();
 }