[Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

[jkorous]

Summary

Since there's no change to ArgExprs between here and the previous early exit starting at L 5333 it's effectively a dead code.

On the other hand a possible counter-argument is that code gets a bit more brittle.

WDYT?

[JDevlieghere]

Assuming ArgExprs doesn't change between those two calls this seems fine.

Sema/SemaExpr.cpp

5338

While you're at it you might as well remove the else branch here.

[jkorous]

Sorry for the delay - I was busy with other things for past two weeks.

Sema/SemaExpr.cpp

5338

Sorry, I am not following. Do you mean just refactoring?

if a
  foo
else
  bar

->

if a
  foo

bar

Or do you really mean removing the else branch? I don't see how that would be NFC.

[JDevlieghere]

Sema/SemaExpr.cpp

5338

Yup, that's what I meant. since we have a return anyway.

[jkorous]

I got some test failure with the patch, still investigating the issue.

Sema/SemaExpr.cpp

if (getLangOpts().CPlusPlus) {
 
     // Determine whether this is a dependent call inside a C++ template,
     // in which case we won't do any semantic analysis now.
     if (Fn->isTypeDependent() || Expr::hasAnyTypeDependentArguments(ArgExprs)) {
       if (ExecConfig) {
         return new (Context) CUDAKernelCallExpr(
             Context, Fn, cast<CallExpr>(ExecConfig), ArgExprs,
             Context.DependentTy, VK_RValue, RParenLoc);
       } else {
 
         tryImplicitlyCaptureThisIfImplicitMemberFunctionAccessWithDependentArgs(
             *this, dyn_cast<UnresolvedMemberExpr>(Fn->IgnoreParens()),
             Fn->getBeginLoc());
 
         return new (Context) CallExpr(
             Context, Fn, ArgExprs, Context.DependentTy, VK_RValue, RParenLoc);
       }
ExprResult Sema::ActOnCallExpr(Scope *Scope, Expr *Fn, SourceLocation LParenLoc,
   }
 
   // Check for overloaded calls.  This can happen even in C due to extensions.
   if (Fn->getType() == Context.OverloadTy) {
     OverloadExpr::FindResult find = OverloadExpr::find(Fn);
 
     // We aren't supposed to apply this logic if there's an '&' involved.
     if (!find.HasFormOfMemberPointer) {
-      if (Expr::hasAnyTypeDependentArguments(ArgExprs))
-        return new (Context) CallExpr(
-            Context, Fn, ArgExprs, Context.DependentTy, VK_RValue, RParenLoc);
       OverloadExpr *ovl = find.Expression;
       if (UnresolvedLookupExpr *ULE = dyn_cast<UnresolvedLookupExpr>(ovl))
         return BuildOverloadedCallExpr(
             Scope, Fn, ULE, LParenLoc, ArgExprs, RParenLoc, ExecConfig,
             /*AllowTypoCorrection=*/true, find.IsAddressOfOperand);
       return BuildCallToMemberFunction(Scope, Fn, LParenLoc, ArgExprs,
                                        RParenLoc);
     }