[analyzer] Dump a reproducible, deterministic ID of program state to exploded graph

[george.karpenkov]

[NoQ]

I very very much appreciate this.

cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

ProgramState(ProgramStateManager *mgr, const Environment& env,
           StoreRef st, GenericDataMap gdm);
 
   /// Copy ctor - We must explicitly define this or else the "Next" ptr
   ///  in FoldingSetNode will also get copied.
   ProgramState(const ProgramState &RHS);
 
   ~ProgramState();
 
+  int64_t getID() const;
+
   /// Return the ProgramStateManager associated with this state.
   ProgramStateManager &getStateManager() const {
     return *stateMgr;
   }
 
   AnalysisManager &getAnalysisManager() const;
 
   /// Return the ConstraintManager.

cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp

switch (Loc.getKind()) {
         else if (Loc.getAs<PostAllocatorCall>())
           Out << "\\lPostAllocatorCall\\l";
 
         break;
       }
     }
 
     ProgramStateRef state = N->getState();
-    Out << "\\|StateID: " << (const void*) state.get()
+    Out << "\\|StateID: " << state->getID() << " ("
+        << (const void*) state.get() << ")"
         << " NodeID: " << (const void*) N << "\\|";
 
     state->printDOT(Out, N->getLocationContext());
 
     Out << "\\l";
 
     if (const ProgramPointTag *tag = Loc.getTag()) {
       Out << "\\|Tag: " << tag->getTagDescription();

cfe/trunk/lib/StaticAnalyzer/Core/ProgramState.cpp

ProgramState::ProgramState(const ProgramState &RHS)
   stateMgr->getStoreManager().incrementReferenceCount(store);
 }
 
 ProgramState::~ProgramState() {
   if (store)
     stateMgr->getStoreManager().decrementReferenceCount(store);
 }
 
+int64_t ProgramState::getID() const {
+  Optional<int64_t> Out = getStateManager().Alloc.identifyObject(this);
+  assert(Out && "Wrong allocator used");
+  assert(*Out % alignof(ProgramState) == 0 && "Wrong alignment information");
+  return *Out / alignof(ProgramState);
+}
+
 ProgramStateManager::ProgramStateManager(ASTContext &Ctx,
                                          StoreManagerCreator CreateSMgr,
                                          ConstraintManagerCreator CreateCMgr,
                                          llvm::BumpPtrAllocator &alloc,
                                          SubEngine *SubEng)
   : Eng(SubEng), EnvMgr(alloc), GDMFactory(alloc),
     svalBuilder(createSimpleSValBuilder(alloc, Ctx, *this)),
     CallEventMgr(new CallEventManager(alloc)), Alloc(alloc) {