This is an archive of the discontinued LLVM Phabricator instance.

Differential D51271

[UBSan] Add missing `%run` prefixes to Pointer tests.
ClosedPublic

Authored by delcypher on Aug 26 2018, 3:41 PM.

Details

Reviewers
vsk
kubamracek
george.karpenkov
Commits
rG4218a0069734: [UBSan] Add missing `%run` prefixes to Pointer tests.
rCRT341298: [UBSan] Add missing `%run` prefixes to Pointer tests.
rL341298: [UBSan] Add missing `%run` prefixes to Pointer tests.
Summary

rdar://problem/41126835

Diff Detail

Event Timeline

delcypher created this revision.Aug 26 2018, 3:41 PM
Herald added a subscriber: Restricted Project. · View Herald TranscriptAug 26 2018, 3:41 PM
Harbormaster completed remote builds in B21932: Diff 162596.Aug 26 2018, 3:41 PM
delcypher added a reviewer: george.karpenkov.Aug 26 2018, 3:51 PM
vsk accepted this revision.Aug 27 2018, 10:23 AM

Thanks!

This revision is now accepted and ready to land.Aug 27 2018, 10:23 AM
Closed by commit rL341298: [UBSan] Add missing `%run` prefixes to Pointer tests. (authored by delcypher). · Explain WhySep 3 2018, 1:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
ubsan/
TestCases/
Pointer/
6 lines
2 lines

Diff 162596

test/ubsan/TestCases/Pointer/index-overflow.cpp

// RUN: %clangxx -fsanitize=pointer-overflow %s -o %t // RUN: %clangxx -fsanitize=pointer-overflow %s -o %t
// RUN: %t 1 2>&1 | FileCheck %s --check-prefix=ERR // RUN: %run %t 1 2>&1 | FileCheck %s --check-prefix=ERR
// RUN: %t 0 2>&1 | FileCheck %s --check-prefix=SAFE // RUN: %run %t 0 2>&1 | FileCheck %s --check-prefix=SAFE
// RUN: %t -1 2>&1 | FileCheck %s --check-prefix=SAFE // RUN: %run %t -1 2>&1 | FileCheck %s --check-prefix=SAFE
#include <stdio.h> #include <stdio.h>
#include <stdint.h> #include <stdint.h>
#include <stdlib.h> #include <stdlib.h>
int main(int argc, char *argv[]) { int main(int argc, char *argv[]) {
// SAFE-NOT: runtime error // SAFE-NOT: runtime error
// ERR: runtime error: pointer index expression with base {{.*}} overflowed to // ERR: runtime error: pointer index expression with base {{.*}} overflowed to
char *p = (char *)(UINTPTR_MAX); char *p = (char *)(UINTPTR_MAX);
printf("%p\n", p + atoi(argv[1])); printf("%p\n", p + atoi(argv[1]));
return 0; return 0;
} }

test/ubsan/TestCases/Pointer/unsigned-index-expression.cpp

// RUN: %clangxx -std=c++11 -fsanitize=pointer-overflow %s -o %t // RUN: %clangxx -std=c++11 -fsanitize=pointer-overflow %s -o %t
// RUN: %t 2>&1 | FileCheck %s // RUN: %run %t 2>&1 | FileCheck %s
int main(int argc, char *argv[]) { int main(int argc, char *argv[]) {
char c; char c;
char *p = &c; char *p = &c;
unsigned long long neg_1 = -1; unsigned long long neg_1 = -1;
// CHECK: unsigned-index-expression.cpp:[[@LINE+1]]:15: runtime error: addition of unsigned offset to 0x{{.*}} overflowed to 0x{{.*}} // CHECK: unsigned-index-expression.cpp:[[@LINE+1]]:15: runtime error: addition of unsigned offset to 0x{{.*}} overflowed to 0x{{.*}}
char *q = p + neg_1; char *q = p + neg_1;
Show All 10 Lines