This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Move analyzer-eagerly-assume to AnalyzerOptions, enable by default
ClosedPublic

Authored by george.karpenkov on Aug 24 2018, 6:44 PM.

Details

Summary

analyzer-eagerly-assume should not be a frontend option, but should be an analyzer option.
Moreover, it should be enabled by default both when invoked via driver or via frontend.

Current situation leads to the fact that most tests are written *without* it, while we are *enabling* it by default -- the fact that should be ideally addressed in future (either by not enabling it by default, or by changing most tests).

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ accepted this revision.Aug 29 2018, 11:49 AM

Should be great as long as various analyzer UIs don't try to enforce this flag manually. Eg., scan-build seems to trust the driver here and doesn't expose it as an option.

This revision is now accepted and ready to land.Aug 29 2018, 11:49 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.