Page MenuHomePhabricator

[clang-tidy] Don't run misc-unused-using-decls check in C++17.
Needs ReviewPublic

Authored by hokein on Aug 21 2018, 8:17 AM.

Details

Reviewers
ilya-biryukov
Summary

It introduces some false positives which are non-trivial to fix.
Ignore running the check in C++17.

Event Timeline

hokein created this revision.Aug 21 2018, 8:17 AM
xazax.hun added inline comments.Aug 21 2018, 8:19 AM
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
35

Isn't the check for getLangOpts().CPlusPlus2a redundant? Shouldn't it imply the C++17 flag?

hokein updated this revision to Diff 161893.Aug 22 2018, 12:57 AM

Remove redundant CPlusPlus2a.

hokein marked an inline comment as done.Aug 22 2018, 12:57 AM
hokein added inline comments.
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
35

Didn't notice it. Yeah, you are right. If CPlusCplus2a also indicates C++17.

JonasToth added inline comments.
test/clang-tidy/misc-unused-using-decls-cxx17.cpp
2

why gnu++17 and not standard?