[NFC] Don't define static function in header (UninitializedObject.h)

[a.elovikov]

Summary

See also http://lists.llvm.org/pipermail/cfe-users/2016-January/000854.html for
the reasons why it's bad.

[Szelethus]

Thanks! Learned something new today then :) This solution looks a lot cleaner as well.

clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h

private:
   bool addFieldToUninits(FieldChainInfo LocalChain);
 };
 
 /// Returns true if T is a primitive type. We defined this type so that for
 /// objects that we'd only like analyze as much as checking whether their
 /// value is undefined or not, such as ints and doubles, can be analyzed with
 /// ease. This also helps ensuring that every special field type is handled
 /// correctly.
-static bool isPrimitiveType(const QualType &T) {
+inline bool isPrimitiveType(const QualType &T) {
   return T->isBuiltinType() || T->isEnumeralType() || T->isMemberPointerType();
 }
 
 // Template method definitions.
 
 template <class FieldNodeT>
 inline FieldChainInfo FieldChainInfo::add(const FieldNodeT &FN) {
   assert(!contains(FN.getRegion()) &&

clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp

if (Optional<nonloc::LazyCompoundVal> RecordV =
     if (DynT->getPointeeType()->isArrayType()) {
       IsAnyFieldInitialized = true;
       return false;
     }
 
     llvm_unreachable("All cases are handled!");
   }
 
-  // Temporary variable to avoid warning from -Wunused-function.
-  bool IsPrimitive = isPrimitiveType(DynT->getPointeeType());
-  assert((IsPrimitive || DynT->isAnyPointerType() || DynT->isReferenceType()) &&
+  assert((isPrimitiveType(DynT->getPointeeType()) || DynT->isAnyPointerType() ||
+          DynT->isReferenceType()) &&
          "At this point FR must either have a primitive dynamic type, or it "
          "must be a null, undefined, unknown or concrete pointer!");
-  (void)IsPrimitive;
 
   if (isPrimitiveUninit(DerefdV)) {
     if (NeedsCastBack)
       return addFieldToUninits(LocalChain.add(NeedsCastLocField(FR, DynT)));
     return addFieldToUninits(LocalChain.add(LocField(FR)));
   }
 
   IsAnyFieldInitialized = true;