This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Add missing lock in the lookup.
ClosedPublic

Authored by hokein on Aug 20 2018, 1:58 AM.

Reviewers

Commits

Repository

rCTE Clang Tools Extra

Build Status

Buildable 21664
Build 21664: arc lint + arc unit

lgtm

This revision is now accepted and ready to land.Aug 20 2018, 1:59 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clangd/

index/

1 line

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines	bool More = false;
for (; !Top.empty(); Top.pop())		for (; !Top.empty(); Top.pop())
Callback(*Top.top().second);		Callback(*Top.top().second);
}		}
return More;		return More;
}		}

void MemIndex::lookup(const LookupRequest &Req,		void MemIndex::lookup(const LookupRequest &Req,
llvm::function_ref<void(const Symbol &)> Callback) const {		llvm::function_ref<void(const Symbol &)> Callback) const {
		std::lock_guard<std::mutex> Lock(Mutex);
for (const auto &ID : Req.IDs) {		for (const auto &ID : Req.IDs) {
auto I = Index.find(ID);		auto I = Index.find(ID);
if (I != Index.end())		if (I != Index.end())
Callback(*I->second);		Callback(*I->second);
}		}
}		}

std::unique_ptr<SymbolIndex> MemIndex::build(SymbolSlab Slab) {		std::unique_ptr<SymbolIndex> MemIndex::build(SymbolSlab Slab) {
Show All 23 Lines