This is an archive of the discontinued LLVM Phabricator instance.

Differential D50960

[clangd] Add missing lock in the lookup.
ClosedPublic

Authored by hokein on Aug 20 2018, 1:58 AM.

Details

Reviewers
ioeric
Commits
rG02465baea238: [clangd] Add missing lock in the lookup.
rL340156: [clangd] Add missing lock in the lookup.
rCTE340156: [clangd] Add missing lock in the lookup.

Diff Detail

Event Timeline

hokein created this revision.Aug 20 2018, 1:58 AM
Herald added subscribers: kadircet, arphaman, jkorous and 2 others. · View Herald TranscriptAug 20 2018, 1:58 AM
ioeric accepted this revision.Aug 20 2018, 1:59 AM

lgtm

This revision is now accepted and ready to land.Aug 20 2018, 1:59 AM
Closed by commit rCTE340156: [clangd] Add missing lock in the lookup. (authored by hokein). · Explain WhyAug 20 2018, 2:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clangd/
index/
1 line

Diff 161447

clangd/index/MemIndex.cpp

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines bool More = false;
for (; !Top.empty(); Top.pop()) for (; !Top.empty(); Top.pop())
Callback(*Top.top().second); Callback(*Top.top().second);
} }
return More; return More;
} }
void MemIndex::lookup(const LookupRequest &Req, void MemIndex::lookup(const LookupRequest &Req,
llvm::function_ref<void(const Symbol &)> Callback) const { llvm::function_ref<void(const Symbol &)> Callback) const {
std::lock_guard<std::mutex> Lock(Mutex);
for (const auto &ID : Req.IDs) { for (const auto &ID : Req.IDs) {
auto I = Index.find(ID); auto I = Index.find(ID);
if (I != Index.end()) if (I != Index.end())
Callback(*I->second); Callback(*I->second);
} }
} }
std::unique_ptr<SymbolIndex> MemIndex::build(SymbolSlab Slab) { std::unique_ptr<SymbolIndex> MemIndex::build(SymbolSlab Slab) {
Show All 23 Lines