Still has quite a lot of false positives, in alpha for now.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Tests have disappeared again.
clang/include/clang/StaticAnalyzer/Core/RetainSummaryManager.h | ||
---|---|---|
533–534 ↗ | (On Diff #161846) | I suspect that this line wasn't intended to be moved around. |
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp | ||
1403–1410 ↗ | (On Diff #161846) | Now enabling OSObjectRetainCount checker would enable the regular RetainCountChecker. If we want to keep them separate, i guess we'll have to make it work both ways and add a flag for the regular retain count checker everywhere in its code. It's easy to forget the check, so we might probably want to add assertions somewhere in emitReport that we at least don't throw warnings from disabled checkers. |
clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp | ||
331–334 ↗ | (On Diff #161846) | Should we check TrackOSObjects here? |
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp | ||
---|---|---|
1403–1410 ↗ | (On Diff #161846) | I think I'm fine with enabling the "regular" one, I don't think it would cause any issues with codebases using OSObject, as they probably would never have CFObject or NSObject. |