This is an archive of the discontinued LLVM Phabricator instance.

Differential D50865

[hwasan] Enable Android logging.
ClosedPublic

Authored by eugenis on Aug 16 2018, 2:32 PM.

Details

Reviewers
vitalybuka
kcc
Commits
rG628e766ca3c4: [hwasan] Enable Android logging.
rL339950: [hwasan] Enable Android logging.
rCRT339950: [hwasan] Enable Android logging.
Summary

Enable syslog as soon as the shadow is mapped.

Diff Detail

Event Timeline

eugenis created this revision.Aug 16 2018, 2:32 PM
Herald added subscribers: kubamracek, srhines. · View Herald TranscriptAug 16 2018, 2:32 PM
Harbormaster completed remote builds in B21597: Diff 161111.Aug 16 2018, 2:32 PM
vitalybuka accepted this revision.Aug 16 2018, 2:55 PM
This revision is now accepted and ready to land.Aug 16 2018, 2:55 PM
Closed by commit rCRT339950: [hwasan] Enable Android logging. (authored by eugenis). · Explain WhyAug 16 2018, 2:56 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptAug 16 2018, 2:56 PM

Revision Contents

PathSize
lib/
hwasan/
3 lines

Diff 161124

lib/hwasan/hwasan.cc

Show First 20 Lines • Show All 192 Lines • ▼ Show 20 Linesvoid __hwasan_init() {
SetCheckFailedCallback(HWAsanCheckFailed); SetCheckFailedCallback(HWAsanCheckFailed);
__sanitizer_set_report_path(common_flags()->log_path); __sanitizer_set_report_path(common_flags()->log_path);
DisableCoreDumperIfNecessary(); DisableCoreDumperIfNecessary();
__hwasan_shadow_init(); __hwasan_shadow_init();
MadviseShadow(); MadviseShadow();
// This may call libc -> needs initialized shadow.
AndroidLogInit();
InitializeInterceptors(); InitializeInterceptors();
InstallDeadlySignalHandlers(HwasanOnDeadlySignal); InstallDeadlySignalHandlers(HwasanOnDeadlySignal);
InstallAtExitHandler(); // Needs __cxa_atexit interceptor. InstallAtExitHandler(); // Needs __cxa_atexit interceptor.
Symbolizer::GetOrInit()->AddHooks(EnterSymbolizer, ExitSymbolizer); Symbolizer::GetOrInit()->AddHooks(EnterSymbolizer, ExitSymbolizer);
InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir); InitializeCoverage(common_flags()->coverage, common_flags()->coverage_dir);
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines