This is an archive of the discontinued LLVM Phabricator instance.

[ASTImporter] Add test for CXXNoexceptExpr
ClosedPublic

Authored by teemperor on Aug 14 2018, 2:31 PM.

Diff Detail

Event Timeline

teemperor created this revision.Aug 14 2018, 2:31 PM
hiraditya added inline comments.
test/Import/cxx-noexcept-expr/test.cpp
1

Can we add a line/comment to explain what this test does? Same for the input files.

a_sidorin accepted this revision.Aug 19 2018, 6:41 AM
a_sidorin added a subscriber: a_sidorin.

Thanks!

This revision is now accepted and ready to land.Aug 19 2018, 6:41 AM
teemperor added inline comments.Aug 21 2018, 10:15 AM
test/Import/cxx-noexcept-expr/test.cpp
1

Well all the 'Import/<node-name>' tests just try importing the respective AST node type and run checks on the node after importing. But we probably should reorganize the test/Import folder in the future, so then we can better document that the tests in the respective 'node-types` folder or so are supposed to do just this kind of check.

This revision was automatically updated to reflect the committed changes.