[analyzer] Fix UninitializedObjectChecker to not crash on uninitialized "id" fields

[george.karpenkov]

Summary

"id" is, interestingly enough, an objcPointerType, but not isPointerType, yet both are covered under isAnyPointerType

[Szelethus]

Thanks! I don't have the resources to check how the checker behaves with objc, so I appreciate these greatly ^-^

[Szelethus]

clang/test/Analysis/objcpp-uninitialized-object.mm

26 ↗

(On Diff #160473)

I just commited a couple changes, this should I believe say "uninitialized pointer".

lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp

if (T->isUnionType()) {
       continue;
     }
 
     if (T->isArrayType()) {
       IsAnyFieldInitialized = true;
       continue;
     }
 
-    if (T->isPointerType() || T->isReferenceType() || T->isBlockPointerType()) {
+    if (T->isAnyPointerType() || T->isReferenceType() || T->isBlockPointerType()) {
       if (isPointerOrReferenceUninit(FR, LocalChain))
         ContainsUninitField = true;
       continue;
     }
 
     if (isPrimitiveType(T)) {
       SVal V = State->getSVal(FieldVal);
 

lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp

 //                   Methods for FindUninitializedFields.
 //===----------------------------------------------------------------------===//
 
 // Note that pointers/references don't contain fields themselves, so in this
 // function we won't add anything to LocalChain.
 bool FindUninitializedFields::isPointerOrReferenceUninit(
     const FieldRegion *FR, FieldChainInfo LocalChain) {
 
-  assert((FR->getDecl()->getType()->isPointerType() ||
+  assert((FR->getDecl()->getType()->isAnyPointerType() ||
           FR->getDecl()->getType()->isReferenceType() ||
           FR->getDecl()->getType()->isBlockPointerType()) &&
          "This method only checks pointer/reference objects!");
 
   SVal V = State->getSVal(FR);
 
   if (V.isUnknown() || V.getAs<loc::ConcreteInt>()) {
     IsAnyFieldInitialized = true;

test/Analysis/objcpp-uninitialized-object.mm

 
 void warnOnUninitializedBlock() {
   StructWithBlock a(10);
 }
 
 void noWarningWhenInitialized() {
   StructWithBlock a;
 }
+
+struct StructWithId {
+  int a;
+  id z; // expected-note{{uninitialized pointer 'this->z'}}
+  StructWithId() : a(0) {} // expected-warning{{1 uninitialized field at the end of the constructor call}}
+};
+
+void warnOnUninitializedId() {
+  StructWithId s;
+}