This is an archive of the discontinued LLVM Phabricator instance.

Differential D5062

[mips][microMIPS] Implement JR16 instruction
ClosedPublic

Authored by jkolek on Aug 26 2014, 2:06 AM.

Details

Reviewers
sstankovic
dsanders
vmedic
Commits
rL219498: [mips][microMIPS] Implement JR16 instruction
Summary

Implement 16-bit microMIPS jump register instruction JR16.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 12942.Aug 26 2014, 2:06 AM
jkolek retitled this revision from to [mips][microMIPS] Implement JR16 instruction.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: dsanders, vmedic.
jkolek added a parent revision: D5049: [mips][microMIPS] Implement ADDIUS5 instruction.
jkolek added a subscriber: zoran.jovanovic.
jkolek updated this revision to Diff 14109.Sep 26 2014, 5:30 AM
jkolek added a reviewer: sstankovic.
sstankovic edited edge metadata.Sep 29 2014, 4:49 AM

LGTM

sstankovic accepted this revision.Sep 29 2014, 4:49 AM
sstankovic edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2014, 4:49 AM
Diffusion closed this revision.Oct 10 2014, 7:13 AM
Diffusion updated this revision to Diff 14728.

Closed by commit rL219498 (authored by zjovanovic).

jkolek edited edge metadata.Nov 18 2014, 5:56 AM
jkolek added a subscriber: Unknown Object (MLST).

Revision Contents

PathSize
lib/
Target/
Mips/
10 lines
test/
MC/
Mips/
5 lines

Diff 14109

lib/Target/Mips/MicroMipsInstrInfo.td

Context not available.
let Defs = [RA]; let Defs = [RA];
} }
// 16-bit Jump Reg
class JumpRegMM16<string opstr, RegisterOperand RO> :
MicroMipsInst16<(outs), (ins RO:$rs), !strconcat(opstr, "\t$rs"),
[], IIBranch, FrmR> {
let hasDelaySlot = 1;
let isBranch = 1;
let isIndirectBranch = 1;
}
// Base class for JRADDIUSP instruction. // Base class for JRADDIUSP instruction.
class JumpRAddiuStackMM16 : class JumpRAddiuStackMM16 :
MicroMipsInst16<(outs), (ins uimm5_lsl2:$imm), "jraddiusp\t$imm", MicroMipsInst16<(outs), (ins uimm5_lsl2:$imm), "jraddiusp\t$imm",
Context not available.
def JALRS16_MM : JumpLinkRegSMM16<"jalrs16", GPR32Opnd>, JALR_FM_MM16<0x0f>; def JALRS16_MM : JumpLinkRegSMM16<"jalrs16", GPR32Opnd>, JALR_FM_MM16<0x0f>;
def JRC16_MM : JumpLinkRegCMM16<"jrc", GPR32Opnd>, JALR_FM_MM16<0x0d>; def JRC16_MM : JumpLinkRegCMM16<"jrc", GPR32Opnd>, JALR_FM_MM16<0x0d>;
def JRADDIUSP : JumpRAddiuStackMM16, JRADDIUSP_FM_MM16<0x18>; def JRADDIUSP : JumpRAddiuStackMM16, JRADDIUSP_FM_MM16<0x18>;
def JR16_MM : JumpRegMM16<"jr16", GPR32Opnd>, JALR_FM_MM16<0x0c>;
class WaitMM<string opstr> : class WaitMM<string opstr> :
InstSE<(outs), (ins uimm10:$code_), !strconcat(opstr, "\t$code_"), [], InstSE<(outs), (ins uimm10:$code_), !strconcat(opstr, "\t$code_"), [],
Context not available.

test/MC/Mips/micromips-16-bit-instructions.s

Context not available.
# CHECK-EL: mflo $9 # encoding: [0x49,0x46] # CHECK-EL: mflo $9 # encoding: [0x49,0x46]
# CHECK-EL: move $25, $1 # encoding: [0x21,0x0f] # CHECK-EL: move $25, $1 # encoding: [0x21,0x0f]
# CHECK-EL: jrc $9 # encoding: [0xa9,0x45] # CHECK-EL: jrc $9 # encoding: [0xa9,0x45]
# CHECK-EL: jr16 $9 # encoding: [0x89,0x45]
# CHECK-EL: nop # encoding: [0x00,0x00,0x00,0x00]
# CHECK-EL: jalr $9 # encoding: [0xc9,0x45] # CHECK-EL: jalr $9 # encoding: [0xc9,0x45]
# CHECK-EL: jraddiusp 20 # encoding: [0x05,0x47] # CHECK-EL: jraddiusp 20 # encoding: [0x05,0x47]
# CHECK-EL: nop # encoding: [0x00,0x00,0x00,0x00] # CHECK-EL: nop # encoding: [0x00,0x00,0x00,0x00]
Context not available.
# CHECK-EB: mflo $9 # encoding: [0x46,0x49] # CHECK-EB: mflo $9 # encoding: [0x46,0x49]
# CHECK-EB: move $25, $1 # encoding: [0x0f,0x21] # CHECK-EB: move $25, $1 # encoding: [0x0f,0x21]
# CHECK-EB: jrc $9 # encoding: [0x45,0xa9] # CHECK-EB: jrc $9 # encoding: [0x45,0xa9]
# CHECK-EB: jr16 $9 # encoding: [0x45,0x89]
# CHECK-EB: nop # encoding: [0x00,0x00,0x00,0x00]
# CHECK-EB: jalr $9 # encoding: [0x45,0xc9] # CHECK-EB: jalr $9 # encoding: [0x45,0xc9]
# CHECK-EB: jraddiusp 20 # encoding: [0x47,0x05] # CHECK-EB: jraddiusp 20 # encoding: [0x47,0x05]
# CHECK-EB: nop # encoding: [0x00,0x00,0x00,0x00] # CHECK-EB: nop # encoding: [0x00,0x00,0x00,0x00]
Context not available.
mflo $9 mflo $9
move $25, $1 move $25, $1
jrc $9 jrc $9
jr16 $9
jalr $9 jalr $9
jraddiusp 20 jraddiusp 20
jalrs16 $9 jalrs16 $9
Context not available.