This is an archive of the discontinued LLVM Phabricator instance.

[LLD][ELF] - Simplify Call-Chain Clustering implementation a bit.
ClosedPublic

Authored by grimar on Aug 12 2018, 6:24 AM.

Details

Summary

Looking at the current implementation and algorithm description,
it does not seem we need to keep vector with all edges for
each cluster and can just remember the best one.

At least with the current implementation, this is NFC change I believe.

This allows to simplify the code a bit, patch shows the change I am suggesting.

Diff Detail

Event Timeline

grimar created this revision.Aug 12 2018, 6:24 AM
ruiu accepted this revision.Aug 27 2018, 3:51 AM

LGTM

ELF/CallGraphSort.cpp
140

Format

This revision is now accepted and ready to land.Aug 27 2018, 3:51 AM
This revision was automatically updated to reflect the committed changes.