This is an archive of the discontinued LLVM Phabricator instance.

[ASTMatchers] Let hasAnyArgument also support CXXUnresolvedConstructExpr
ClosedPublic

Authored by shuaiwang on Aug 11 2018, 10:36 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

shuaiwang created this revision.Aug 11 2018, 10:36 PM
aaron.ballman requested changes to this revision.Aug 12 2018, 6:58 AM

Please be sure to regenerate the AST matcher documentation as well, as I'd expect to see some documentation changes from this.

include/clang/AST/ExprCXX.h
3436 ↗(On Diff #160251)

Please name this const_arg_range for consistency.

This revision now requires changes to proceed.Aug 12 2018, 6:58 AM

update ast matchers doc

shuaiwang marked an inline comment as done.Aug 12 2018, 10:44 AM
shuaiwang added inline comments.
include/clang/AST/ExprCXX.h
3436 ↗(On Diff #160251)

arg_const_range is more widely in clang

aaron.ballman added inline comments.Aug 12 2018, 2:20 PM
include/clang/AST/ExprCXX.h
3436 ↗(On Diff #160251)

arg_const_range makes no sense -- the range is of constant args, not an argument over a constant range. Also, it's weird to have const_arg_iterator with arg_const_range in the same class. I've cleaned up those few instances in r339527. Thanks for pointing this out!

shuaiwang updated this revision to Diff 160273.Aug 12 2018, 2:43 PM
shuaiwang marked 3 inline comments as done.

arg_const_range -> const_arg_range

This revision is now accepted and ready to land.Aug 12 2018, 2:57 PM
This revision was automatically updated to reflect the committed changes.