Page MenuHomePhabricator

[OMPT] Make omp_control_tool() compliant when called from Fortran programs
ClosedPublic

Authored by hbae on Aug 10 2018, 9:05 AM.

Details

Summary

This change fixes an incorrect behavior of the omp_control_tool function when
called from Fortran applications.
A tool callback function for this event is supposed to get NULL for the third
argument according to the specification, but the current implementation just
passes a garbage value. A possible fix is to use the OPTIONAL attribute for the
third argument.

Diff Detail

Repository
rL LLVM

Event Timeline

hbae created this revision.Aug 10 2018, 9:05 AM
protze.joachim accepted this revision.Aug 10 2018, 9:38 AM

Thanks for catching this. It seems like we need some Fortran tests for OMPT.
LGTM

This revision is now accepted and ready to land.Aug 10 2018, 9:38 AM
This revision was automatically updated to reflect the committed changes.