This is an archive of the discontinued LLVM Phabricator instance.

WIP: Ensure that the type of size_t is represended as one of the fixed width types
AbandonedPublic

Authored by sbc100 on Aug 8 2018, 2:10 PM.

Details

Reviewers
None
Summary

We recently changes size_t on wasm from int to long which
had the effect of making the type of size_t (long) not match either
int32_t or int64_t.

This solution is not very elegant but fixes the build issues that
resulted from this change.

Diff Detail

Event Timeline

sbc100 created this revision.Aug 8 2018, 2:10 PM
sbc100 updated this revision to Diff 159794.Aug 8 2018, 2:11 PM

remove debugging

sbc100 abandoned this revision.Aug 8 2018, 5:51 PM
joerg added a subscriber: joerg.Aug 15 2018, 2:53 PM

I don't understand the desire for this logic. Why can't wasm override the rest of the types if it wants to have something special?

Please ignore this change, I had thought we wanted size_t to match either int32_t or int64_t, but it turns out that isn't a requirement and that code that expects this to be true needs fixing.