This is an archive of the discontinued LLVM Phabricator instance.

Port getStartLoc -> getBeginLoc
ClosedPublic

Authored by steveire on Aug 6 2018, 12:42 PM.

Diff Detail

Event Timeline

steveire created this revision.Aug 6 2018, 12:42 PM
rsmith added a reviewer: hans.Aug 6 2018, 2:16 PM
rsmith added a comment.Aug 6 2018, 2:18 PM

+Hans (release manager for LLVM 7)

Hans, this patch series will affect the API of common Clang classes, resulting in patches to Clang SVN needing some (mechanical) modifications to be applied to the Clang 7 release branch if we land it now. What do you think about that? Would you prefer that we wait until after the 7.0.0 release to make cherry-picks easier?

hans added a comment.Aug 6 2018, 11:17 PM

+Hans (release manager for LLVM 7)

Hans, this patch series will affect the API of common Clang classes, resulting in patches to Clang SVN needing some (mechanical) modifications to be applied to the Clang 7 release branch if we land it now. What do you think about that? Would you prefer that we wait until after the 7.0.0 release to make cherry-picks easier?

Thanks for the heads up. It looks mechanical enough that if it does cause merge conflicts, they will be easy enough to resolve. No need to wait.

Thanks Hans. Yes, I made these patches with some simple sed oneliners.

Once these are approved in principle, I'll re-generate them before pushing.

I have also run clang-format on them, but didn't update Phab with the results to reduce noise.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 9 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.