This is an archive of the discontinued LLVM Phabricator instance.

Differential D50276

[clang] Fix broken include_next in float.h
ClosedPublic

Authored by ldionne on Aug 3 2018, 3:41 PM.

Details

Reviewers
jfb
Commits
rG58529c3f5739: [clang] Fix broken include_next in float.h
rC339016: [clang] Fix broken include_next in float.h
rL339016: [clang] Fix broken include_next in float.h
Summary

The code defines FLOAT_H and then includes the next <float.h>, which is
guarded on FLOAT_H so it gets skipped entirely. This commit uses the header
guard __CLANG_FLOAT_H, like other headers (such as limits.h) do.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Aug 3 2018, 3:41 PM
Herald added subscribers: cfe-commits, dexonsmith. · View Herald TranscriptAug 3 2018, 3:41 PM
Harbormaster completed remote builds in B21065: Diff 159109.Aug 3 2018, 3:41 PM
jfb accepted this revision.Aug 3 2018, 3:58 PM
This revision is now accepted and ready to land.Aug 3 2018, 3:58 PM
Closed by commit rL339016: [clang] Fix broken include_next in float.h (authored by ldionne). · Explain WhyAug 6 2018, 7:30 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 6 2018, 7:30 AM

Revision Contents

PathSize
cfe/
trunk/
lib/
Headers/
6 lines

Diff 159299

cfe/trunk/lib/Headers/float.h

Show All 15 Lines
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE. * THE SOFTWARE.
* *
*===-----------------------------------------------------------------------=== *===-----------------------------------------------------------------------===
*/ */
#ifndef __FLOAT_H #ifndef __CLANG_FLOAT_H
#define __FLOAT_H #define __CLANG_FLOAT_H
/* If we're on MinGW, fall back to the system's float.h, which might have /* If we're on MinGW, fall back to the system's float.h, which might have
* additional definitions provided for Windows. * additional definitions provided for Windows.
* For more details see http://msdn.microsoft.com/en-us/library/y0ybw9fy.aspx * For more details see http://msdn.microsoft.com/en-us/library/y0ybw9fy.aspx
* *
* Also fall back on Darwin to allow additional definitions and * Also fall back on Darwin to allow additional definitions and
* implementation-defined values. * implementation-defined values.
*/ */
▲ Show 20 Lines • Show All 118 Lines • ▼ Show 20 Lines
# define FLT16_MAX_EXP __FLT16_MAX_EXP__ # define FLT16_MAX_EXP __FLT16_MAX_EXP__
# define FLT16_MAX_10_EXP __FLT16_MAX_10_EXP__ # define FLT16_MAX_10_EXP __FLT16_MAX_10_EXP__
# define FLT16_MAX __FLT16_MAX__ # define FLT16_MAX __FLT16_MAX__
# define FLT16_EPSILON __FLT16_EPSILON__ # define FLT16_EPSILON __FLT16_EPSILON__
# define FLT16_MIN __FLT16_MIN__ # define FLT16_MIN __FLT16_MIN__
# define FLT16_TRUE_MIN __FLT16_TRUE_MIN__ # define FLT16_TRUE_MIN __FLT16_TRUE_MIN__
#endif /* __STDC_WANT_IEC_60559_TYPES_EXT__ */ #endif /* __STDC_WANT_IEC_60559_TYPES_EXT__ */
#endif /* __FLOAT_H */ #endif /* __CLANG_FLOAT_H */