Page MenuHomePhabricator

Add test for changing build configuration
ClosedPublic

Authored by simark on Aug 3 2018, 7:42 AM.

Details

Summary

This patch adds tests for the two ways of changing build configuration
(pointing to a particular compile_commands.json):

  • Through the workspace/didChangeConfiguration notification.
  • Through the initialize request.

Event Timeline

simark created this revision.Aug 3 2018, 7:42 AM

This was not tested on windows yet.

simark updated this revision to Diff 159050.Aug 3 2018, 10:59 AM

The tests now work on Windows, I added some path adjustment steps.

arphaman accepted this revision.Aug 3 2018, 12:36 PM

Thanks! This LGTM.

This revision is now accepted and ready to land.Aug 3 2018, 12:36 PM
This revision was automatically updated to reflect the committed changes.

Thanks! This LGTM.

Well, thanks for the hints!