Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
test/Driver/aarch64-cpus.c | ||
---|---|---|
10 ↗ | (On Diff #158717) | Why do these need new check prefixes? All of the RUN lines above are selecting little-endian, so I'd expect GENERIC and GENERIC-LE to be the same. |
test/Driver/aarch64-cpus.c | ||
---|---|---|
10 ↗ | (On Diff #158717) | Ok, good point. The output is slightly different. For the little-endian runs above the output is: "-triple" "aarch64" and with "-target aarch64_be -mlittle-endian" the output is: "-triple" "aarch64--" As we don't want to be too generic and match "aarch64{{.*}}", I will therefore change the GENERIC checks to match "aarch64{{[--]*}}", and indeed remove GENERIC-LE. |
test/Driver/aarch64-cpus.c | ||
---|---|---|
10 ↗ | (On Diff #158717) | I think that works, but it's a strange way to write the regex. You have "-" twice inside a character set, which is the same as only having it once, so "[--]*" matches zero or more occurrences of "-". I'd suggest using something like "(--)?" which matches either "--" or nothing. |
test/Driver/aarch64-cpus.c | ||
---|---|---|
10 ↗ | (On Diff #158717) | Ah, of course, thanks! That was a bit silly, will fix. |