This is an archive of the discontinued LLVM Phabricator instance.

[ValueTracking] Teach isKnownNonNullFromDominatingCondition about AND
ClosedPublic

Authored by mkazantsev on Aug 2 2018, 1:35 AM.

Diff Detail

Event Timeline

mkazantsev created this revision.Aug 2 2018, 1:35 AM
xbolva00 added inline comments.
test/Transforms/LICM/hoist-deref-load.ll
601

check

Fixed typos in test's comments.

mkazantsev marked an inline comment as done.Aug 3 2018, 12:47 AM

I was wondering where is a good place for this: https://bugs.llvm.org/show_bug.cgi?id=38349 (in the true block, we know some info about bits of x, so this info should be propagated to the whole block)

Here we are dealing with i1 AND only, so it should not be relevant here. The example in this bug looks like something to handle in InstCombine.

reames accepted this revision.Aug 3 2018, 10:06 AM

LGTM

This revision is now accepted and ready to land.Aug 3 2018, 10:06 AM
This revision was automatically updated to reflect the committed changes.
mkazantsev reopened this revision.Aug 6 2018, 2:25 AM

This patch has exposed sanitizer failures, likely something that already existed and now got exposed. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/14348. Investigating.

This revision is now accepted and ready to land.Aug 6 2018, 2:25 AM
This revision was automatically updated to reflect the committed changes.