Page MenuHomePhabricator

[c-index-test] Use correct executable path to discover resource directory.
ClosedPublic

Authored by vsapsai on Aug 1 2018, 2:45 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vsapsai created this revision.Aug 1 2018, 2:45 PM
akyrtzi added inline comments.Aug 1 2018, 3:49 PM
clang/tools/c-index-test/core_main.cpp
210 ↗(On Diff #158643)

Could you move this up to indextest_core_main and have printSourceSymbols() accept the executable path directly ?
This would come in handy to avoid duplication if we later on add another function that also needs the executable path.

vsapsai updated this revision to Diff 158658.Aug 1 2018, 4:16 PM
  • Address review comment: move getMainExecutable to indextest_core_main.
vsapsai marked an inline comment as done.Aug 1 2018, 4:18 PM
vsapsai added inline comments.
clang/tools/c-index-test/core_main.cpp
210 ↗(On Diff #158643)

Done. Thanks for the suggestion, I think the code looks better now.

akyrtzi accepted this revision.Aug 1 2018, 5:32 PM

LGTM!

This revision is now accepted and ready to land.Aug 1 2018, 5:32 PM
This revision was automatically updated to reflect the committed changes.
vsapsai marked an inline comment as done.

Thanks for the review!