nathawes (Nathan Hawes)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2017, 1:27 PM (48 w, 3 d)

Recent Activity

Thu, Jan 18

nathawes updated the diff for D39050: Add index-while-building support to Clang.
  • Applied the various refactorings suggested by @ioeric
  • Extended c-index-test with a new option to print out the collected unit indexing data, and
  • Added tests for the unit indexing functionality using the new option
  • Fixed formatting
Thu, Jan 18, 3:03 PM
nathawes planned changes to D39050: Add index-while-building support to Clang.

@ioeric I should have an updated patch up shortly with your inline comments addressed + new tests. Thanks again for reviewing!

Thu, Jan 18, 2:36 PM

Dec 19 2017

nathawes added a dependency for D41407: Add index-while-building support to Clang - Part 3: D40992: Add index-while-building support to Clang - Part 2.
Dec 19 2017, 11:34 AM
nathawes added a dependent revision for D40992: Add index-while-building support to Clang - Part 2: D41407: Add index-while-building support to Clang - Part 3.
Dec 19 2017, 11:34 AM
nathawes planned changes to D41407: Add index-while-building support to Clang - Part 3.

This needs to be reworked to remove its dependence on blocks.

Dec 19 2017, 11:34 AM
nathawes created D41407: Add index-while-building support to Clang - Part 3.
Dec 19 2017, 11:33 AM
nathawes planned changes to D40992: Add index-while-building support to Clang - Part 2.
Dec 19 2017, 10:59 AM
nathawes updated the diff for D40992: Add index-while-building support to Clang - Part 2.

Updated to account for the most recent changes to Part 1

Dec 19 2017, 10:59 AM
nathawes updated the summary of D40992: Add index-while-building support to Clang - Part 2.
Dec 19 2017, 10:56 AM
nathawes updated the diff for D39050: Add index-while-building support to Clang.

Fix out of date header comment in FileIndexData.h

Dec 19 2017, 10:50 AM

Dec 18 2017

nathawes updated the diff for D39050: Add index-while-building support to Clang.

I've refactored the indexing/dependency data collection out from the writing with the new IndexUnitDataConsumer class, and made other smaller changes to address the feedback from @ioeric.

Dec 18 2017, 2:58 PM
nathawes added inline comments to D39050: Add index-while-building support to Clang.
Dec 18 2017, 2:05 PM

Dec 12 2017

nathawes planned changes to D39050: Add index-while-building support to Clang.

Thanks for taking another look @ioeric – I'll work through your comments and update.

Dec 12 2017, 11:51 AM

Dec 7 2017

nathawes added a dependency for D40992: Add index-while-building support to Clang - Part 2: D39050: Add index-while-building support to Clang.
Dec 7 2017, 4:29 PM
nathawes added a dependent revision for D39050: Add index-while-building support to Clang: D40992: Add index-while-building support to Clang - Part 2.
Dec 7 2017, 4:29 PM
nathawes planned changes to D40992: Add index-while-building support to Clang - Part 2.
Dec 7 2017, 4:29 PM
nathawes retitled D40992: Add index-while-building support to Clang - Part 2 from Add index-while-building support to Clang to Add index-while-building support to Clang - Part 2.
Dec 7 2017, 4:27 PM
nathawes created D40992: Add index-while-building support to Clang - Part 2.
Dec 7 2017, 4:13 PM
nathawes updated the diff for D39050: Add index-while-building support to Clang.

Worked through the comments from @ioeric and split the code for writing out the collected indexing data into a separate patch.

Dec 7 2017, 4:02 PM
nathawes added inline comments to D39050: Add index-while-building support to Clang.
Dec 7 2017, 3:42 PM

Nov 27 2017

nathawes added a comment to D39050: Add index-while-building support to Clang.

Thanks for the feedback @malaperle!

Nov 27 2017, 2:40 PM

Nov 9 2017

nathawes planned changes to D39050: Add index-while-building support to Clang.

I think this patch should be split into a number of smaller patches to help the review process.

Things like tools/IndexStore, DirectoryWatcher and other components that are not directly needed right now should definitely be in their own patches.
It would be nice to find some way to split the implementation into multiple patches as well.

+1.

This is a lot of work (but great work!) for one patch. Smaller/incremental patches help reviewers understand and (hopefully) capture potential improvement of the design. I would really appreciate it if you could further split the patch.

Nov 9 2017, 2:46 PM

Nov 6 2017

nathawes updated the diff for D39050: Add index-while-building support to Clang.

Based on @arphaman's feedback:

  • Pulled the index store related diagnostics out into their own category/diagnostic group
  • Removed the CLANG_PROJECT_INDEX_PATH env var check.
  • Swapped "/" used in a few places as a separator/root with the equivalent llvm::sys::path call.
  • Fixed the typo/convention/documentation issues and simplifications pointed out so far
Nov 6 2017, 7:24 PM
nathawes added inline comments to D39050: Add index-while-building support to Clang.
Nov 6 2017, 6:49 PM

Oct 31 2017

nathawes planned changes to D39050: Add index-while-building support to Clang.

Thanks @arphaman! I'll work through your comments and update.

Oct 31 2017, 4:45 PM
nathawes updated the diff for D39050: Add index-while-building support to Clang.

I've split out the parts for reading and managing the store data (the IndexStore and DirectoryWatcher libraries) into a separate patch, so this one is now just about the -index-store-path option and everything necessary to write out the index data to the provided path.

Oct 31 2017, 3:11 PM

Oct 18 2017

nathawes created D39050: Add index-while-building support to Clang.
Oct 18 2017, 6:09 AM

Aug 11 2017

nathawes created D36641: [index] Update indexing to handle CXXDeductionGuideDecls properly.
Aug 11 2017, 6:54 PM

May 19 2017

nathawes updated the diff for D33346: Fix forward declarations interfering with USR generation of external source symbols.
May 19 2017, 1:45 PM
nathawes planned changes to D33346: Fix forward declarations interfering with USR generation of external source symbols.

Ah sorry, missed the "Decl::" part of your recommendation. I'll move it.

May 19 2017, 12:54 PM
nathawes updated the diff for D33346: Fix forward declarations interfering with USR generation of external source symbols.
May 19 2017, 11:02 AM

May 18 2017

nathawes updated the diff for D33346: Fix forward declarations interfering with USR generation of external source symbols.
May 18 2017, 8:34 PM
nathawes created D33346: Fix forward declarations interfering with USR generation of external source symbols.
May 18 2017, 7:16 PM

Mar 21 2017

nathawes accepted D31179: Objective-C categories should support attributes.

Thanks for this – looks good to me!

Mar 21 2017, 9:37 AM

Mar 17 2017

nathawes updated the diff for D30730: [indexer] Add references to the parent type where its name appears in constructor and destructor definitions and declarations.
Mar 17 2017, 4:38 PM

Mar 13 2017

nathawes updated the summary of D30907: [indexer] Add references for ObjC getter=/setter= property attributes and related property getter/setter role fixes.
Mar 13 2017, 12:49 PM
nathawes created D30907: [indexer] Add references for ObjC getter=/setter= property attributes and related property getter/setter role fixes.
Mar 13 2017, 12:30 PM

Mar 7 2017

nathawes created D30730: [indexer] Add references to the parent type where its name appears in constructor and destructor definitions and declarations.
Mar 7 2017, 5:47 PM

Mar 6 2017

nathawes created D30674: [indexer] Don't index symbol definitions marked with the new ExternalSourceSymbolAttr and namespace their USRs using the Attr's definedIn field.
Mar 6 2017, 5:26 PM

Feb 23 2017

nathawes created D30304: [indexer] Expose the logic for indexing local symbols through c-index-test and add tests for it.
Feb 23 2017, 10:17 AM

Feb 16 2017

nathawes updated the diff for D30012: [indexer] Relate properties to their backing ivars and mark implicit getters and setters with the Implicit role .

Remove pointless cast.

Feb 16 2017, 2:58 PM
nathawes updated the diff for D30012: [indexer] Relate properties to their backing ivars and mark implicit getters and setters with the Implicit role .

Also report an implicit property definition (with relation to the ivar), getter and setter when the @synthesize is implicit.

Feb 16 2017, 11:32 AM

Feb 15 2017

nathawes created D30012: [indexer] Relate properties to their backing ivars and mark implicit getters and setters with the Implicit role .
Feb 15 2017, 3:28 PM