This is an archive of the discontinued LLVM Phabricator instance.

Delete MacOSXFrameBackchain unwind logic (NFC)
AcceptedPublic

Authored by vsk on Aug 1 2018, 12:55 PM.

Details

Summary

This code looks like a good reference for building a new unwinder, but
is currently unused, so there's no need to keep it.

Diff Detail

Event Timeline

vsk created this revision.Aug 1 2018, 12:55 PM

Deleting dead code is always good; I'll let Jason sign this off though.

jasonmolenda accepted this revision.Oct 22 2018, 10:02 AM

Sorry for not replying to this. Yes the code is unused - it was the initial unwinder implementation when lldb is very young, before we had our current one. The main reason to keep it around is (as you say) an example of the simplest unwinder someone might use when porting lldb to a new platform. I don't feel strongly about it one way or the other, I'm fine with removing it if that's what you want to do.

This revision is now accepted and ready to land.Oct 22 2018, 10:02 AM
lldb/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.h