This is an archive of the discontinued LLVM Phabricator instance.

Differential D50108

[analyzer] Forward arguments in registerChecker to avoid accidental copies
ClosedPublic

Authored by george.karpenkov on Jul 31 2018, 3:05 PM.

Details

Reviewers
dcoughlin
NoQ
Commits
rG3cff19be36fc: [analyzer] Forward arguments in registerChecker to avoid accidental copies
rC338753: [analyzer] Forward arguments in registerChecker to avoid accidental copies
rL338753: [analyzer] Forward arguments in registerChecker to avoid accidental copies

Diff Detail

Repository
rL LLVM

Revision Contents

PathSize
cfe/
trunk/
include/
clang/
StaticAnalyzer/
Core/
4 lines

Diff 158806

cfe/trunk/include/clang/StaticAnalyzer/Core/CheckerManager.h

Show First 20 Lines • Show All 143 Lines • ▼ Show 20 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/// Used to register checkers. /// Used to register checkers.
/// All arguments are automatically passed through to the checker /// All arguments are automatically passed through to the checker
/// constructor. /// constructor.
/// ///
/// \returns a pointer to the checker object. /// \returns a pointer to the checker object.
template <typename CHECKER, typename... AT> template <typename CHECKER, typename... AT>
CHECKER *registerChecker(AT... Args) { CHECKER *registerChecker(AT &&... Args) {
CheckerTag tag = getTag<CHECKER>(); CheckerTag tag = getTag<CHECKER>();
CheckerRef &ref = CheckerTags[tag]; CheckerRef &ref = CheckerTags[tag];
if (ref) if (ref)
return static_cast<CHECKER *>(ref); // already registered. return static_cast<CHECKER *>(ref); // already registered.
CHECKER *checker = new CHECKER(Args...); CHECKER *checker = new CHECKER(std::forward<AT>(Args)...);
checker->Name = CurrentCheckName; checker->Name = CurrentCheckName;
CheckerDtors.push_back(CheckerDtor(checker, destruct<CHECKER>)); CheckerDtors.push_back(CheckerDtor(checker, destruct<CHECKER>));
CHECKER::_register(checker, *this); CHECKER::_register(checker, *this);
ref = checker; ref = checker;
return checker; return checker;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 482 Lines • Show Last 20 Lines