Add a CommandGuide for llvm-objdump summarizing its usage along with some
general context.
Details
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 20886 Build 20886: arc lint + arc unit
Event Timeline
docs/CommandGuide/llvm-objdump.rst | ||
---|---|---|
282 | Probably doc should be used instead of manpage. |
docs/CommandGuide/llvm-objdump.rst | ||
---|---|---|
282 | Can you explain? This file is written in the same style as all the other documents in llvm/docs, in rst which can be converted into html, man, epub or whatever you like. |
docs/CommandGuide/llvm-objdump.rst | ||
---|---|---|
282 | Oh I see what you mean. I'll have a look. |
Specify a manpages_url so that CommandGuide references can be used both
as traditional UNIX man-page references and also as nicely hyperlinked
documentation.
Given how mach-o is radically different from ELF, it might make sense to sort or group ELF and mach-o specific options. Right now we only call out options that only work on Mach-o, but I assume some of the options only work on ELF and/or COFF. Might make sense to document that behavior correctly too.
Below I've marked out a few places where mach-o options are missing the annotation.
docs/CommandGuide/llvm-objdump.rst | ||
---|---|---|
28 | Does this require -macho? | |
56 | I assume this also requires -macho? | |
77 | requires -macho? | |
106 | requires -macho? | |
173 | Maybe change "Mach-O-only" to "requires -macho" for consistency. | |
185 | I assume this also requires -macho? | |
201 | Side note for a separate conversation. Do we really need this flag? Is there a reason we can't just use the magic bits at the beginning of the file stream to set the mode? |
The short summary is "-macho" doesn't mean the target file is Mach-O. "-macho" means use the Mach-O specific file parser for walking the file contents, instead of using llvm-Object. When run in this way llvm-objdump will display information in a different way. Like it or hate it, it's what llvm-objdump does currently.
docs/CommandGuide/llvm-objdump.rst | ||
---|---|---|
28 | No. The input file must be Mach-O (I assume) but you don't need to use the "-macho" specific binary parser. | |
56 | No. The input file must be Mach-O (I assume) but you don't need to use the "-macho" specific binary parser. | |
77 | No. The input file must be Mach-O (I assume) but you don't need to use the "-macho" specific binary parser. | |
106 | No. The input file must be Mach-O (I assume) but you don't need to use the "-macho" specific binary parser. | |
173 | Actually, looks like the -cfg option has been removed from newer objdumps, so I'll pull it from the CommandGuide. | |
201 | This flag is basically magic sauce meaning "run llvm-objdump in a otool compatible way", affecting both how the data is consumed and how it is printed. You can verify this yourself by comparing the output of "llvm-objdump -r" and "llvm-objdump -r -macho". It's entirely possible that general purpose developer tools would like to have a common llvm-y way of describing object file details, such as for some kind of CI system or packaging automation. So the same way you should use the high-level llvm-Object API to return data for general files, you can use the high-level llvm-objdump CLI to return this same data. As Mach-O specific features that were implemented using the llbm-Ojbect API, one could argue that those features should have been made in the Mach-O specific parser instead of llvm-Object. I am going to argue that changing the implementation of llvm-objdump is beyond the scope of my task, which is to make a CommandGuide describing llvm-objdump's current behavior. :) |
One last small fix
docs/CommandGuide/llvm-objdump.rst | ||
---|---|---|
277 | I think what you want here is: :program:`llvm-nm` That should produce the correct link in both the online and manpage documentation. |
It turns out :program: does not make a hyperlink in the comman guide. Email with details sent.
The :manpage: Sphinx Role does one job beyond a basic style change, and that is let you carve up the man ref syntax <page>(<section>) and arrange it into a URL. I have modified the docs/conf.py file to do this for llvm.org in the first round of review feedback. So I believe with great confidence that :manpage: is the correct Sphinx Role to use for the “See Also” section of this (and all) CommandGuide pages. It may be the only job it is good for, but for this task, I haven’t seen anything better so far.
@mtrent and I talked offline, and he explained how the sphinx documentation covers the manpage and program directives, and I agree with his assertion that using manpage is correct.
Does this require -macho?