This is an archive of the discontinued LLVM Phabricator instance.

Differential D49934

AMDGPU: Allow fp32-denormals feaure for r600 targets
ClosedPublic

Authored by jvesely on Jul 27 2018, 1:38 PM.

Details

Reviewers
arsenm
tstellar
Commits
rG7f4ef00eb20e: Merging r338569: --------------------------------------------------------------…
rG5ba1b4bdab18: AMDGPU: Allow fp32-denormals feature for r600 targets
rL339103: Merging r338569:
rL338569: AMDGPU: Allow fp32-denormals feature for r600 targets
Summary

This was accidentally removed in r335942.

Diff Detail

Repository
rL LLVM

Event Timeline

jvesely created this revision.Jul 27 2018, 1:38 PM
Herald added subscribers: jfb, t-tye, tpr and 5 others. · View Herald TranscriptJul 27 2018, 1:38 PM
jvesely mentioned this in D49650: Targets/AMDGPU: Don't set fp32-denormals feature for r600.Jul 27 2018, 2:04 PM
jvesely mentioned this in D49649: AMDGPU/R600: Don't set fp32-denormals feature for r600.
arsenm accepted this revision.Jul 30 2018, 5:22 AM

LGTM

This revision is now accepted and ready to land.Jul 30 2018, 5:22 AM
arsenm added inline comments.Jul 30 2018, 5:23 AM
test/CodeGen/AMDGPU/target-features.ll
1–3 ↗(On Diff #157756)

This isn't really a .ll or codegen test. I'm not sure where this should really go.

It also won't stay updated once more features are added, so maybe the test should just be dropped

Closed by commit rL338569: AMDGPU: Allow fp32-denormals feature for r600 targets (authored by jvesely). · Explain WhyAug 1 2018, 8:05 AM
This revision was automatically updated to reflect the committed changes.
jvesely added a comment.Aug 1 2018, 8:06 AM

Merged without the test. thanks

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
AMDGPU/
9 lines
9 lines

Diff 158543

llvm/trunk/lib/Target/AMDGPU/AMDGPU.td

Show First 20 Lines • Show All 261 Lines • ▼ Show 20 Linesdef FeatureD16PreservesUnusedBits : SubtargetFeature<
"unused bits. Otherwise instructions defined by HasD16LoadStore predicate " "unused bits. Otherwise instructions defined by HasD16LoadStore predicate "
"zero unused bits." "zero unused bits."
>; >;
//===------------------------------------------------------------===// //===------------------------------------------------------------===//
// Subtarget Features (options and debugging) // Subtarget Features (options and debugging)
//===------------------------------------------------------------===// //===------------------------------------------------------------===//
// Some instructions do not support denormals despite this flag. Using
// fp32 denormals also causes instructions to run at the double
// precision rate for the device.
def FeatureFP32Denormals : SubtargetFeature<"fp32-denormals",
"FP32Denormals",
"true",
"Enable single precision denormal handling"
>;
// Denormal handling for fp64 and fp16 is controlled by the same // Denormal handling for fp64 and fp16 is controlled by the same
// config register when fp16 supported. // config register when fp16 supported.
// TODO: Do we need a separate f16 setting when not legal? // TODO: Do we need a separate f16 setting when not legal?
def FeatureFP64FP16Denormals : SubtargetFeature<"fp64-fp16-denormals", def FeatureFP64FP16Denormals : SubtargetFeature<"fp64-fp16-denormals",
"FP64FP16Denormals", "FP64FP16Denormals",
"true", "true",
"Enable double and half precision denormal handling", "Enable double and half precision denormal handling",
[FeatureFP64] [FeatureFP64]
▲ Show 20 Lines • Show All 460 Lines • Show Last 20 Lines

llvm/trunk/lib/Target/AMDGPU/AMDGPUFeatures.td

Show All 13 Lines
>; >;
def FeatureFMA : SubtargetFeature<"fmaf", def FeatureFMA : SubtargetFeature<"fmaf",
"FMA", "FMA",
"true", "true",
"Enable single precision FMA (not as fast as mul+add, but fused)" "Enable single precision FMA (not as fast as mul+add, but fused)"
>; >;
// Some instructions do not support denormals despite this flag. Using
// fp32 denormals also causes instructions to run at the double
// precision rate for the device.
def FeatureFP32Denormals : SubtargetFeature<"fp32-denormals",
"FP32Denormals",
"true",
"Enable single precision denormal handling"
>;
class SubtargetFeatureLocalMemorySize <int Value> : SubtargetFeature< class SubtargetFeatureLocalMemorySize <int Value> : SubtargetFeature<
"localmemorysize"#Value, "localmemorysize"#Value,
"LocalMemorySize", "LocalMemorySize",
!cast<string>(Value), !cast<string>(Value),
"The size of local memory in bytes" "The size of local memory in bytes"
>; >;
def FeatureLocalMemorySize0 : SubtargetFeatureLocalMemorySize<0>; def FeatureLocalMemorySize0 : SubtargetFeatureLocalMemorySize<0>;
Show All 31 Lines