Page MenuHomePhabricator

[ASTmporter] SourceRange-free function parameter checking for declarations
ClosedPublic

Authored by gerazo on Jul 25 2018, 5:32 AM.

Details

Summary

The previous code which avoided infinite recursion (because of reparsing declarations in function parameter lists) contained SourceRange dependent code which had some problems when parameter types were coming from macros. The new solution is not using macros and therefore much safer. A couple of importer problems are fixed in redis and tmux by this fix. Various unittests are included.

Diff Detail

Repository
rL LLVM

Event Timeline

gerazo created this revision.Jul 25 2018, 5:32 AM
a_sidorin accepted this revision.Aug 1 2018, 7:41 AM

LGTM. Thank you!

This revision is now accepted and ready to land.Aug 1 2018, 7:41 AM
This revision was automatically updated to reflect the committed changes.