This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Switch default dwarf version to 2
ClosedPublic

Authored by kzhuravl on Jul 20 2018, 1:27 PM.

Reviewers

Commits

Summary

There were some problems unearthed with version 5, which I am going to look at.

LGTM

This revision is now accepted and ready to land.Jul 20 2018, 1:29 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Driver/

ToolChains/

2 lines

test/

Driver/

2 lines

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines	const StringRef getOptionDefault(options::ID OptID) const {
auto opt = OptionsDefault.find(OptID);		auto opt = OptionsDefault.find(OptID);
assert(opt != OptionsDefault.end() && "No Default for Option");		assert(opt != OptionsDefault.end() && "No Default for Option");
return opt->second;		return opt->second;
}		}

public:		public:
AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple,		AMDGPUToolChain(const Driver &D, const llvm::Triple &Triple,
const llvm::opt::ArgList &Args);		const llvm::opt::ArgList &Args);
unsigned GetDefaultDwarfVersion() const override { return 5; }		unsigned GetDefaultDwarfVersion() const override { return 2; }
bool IsIntegratedAssemblerDefault() const override { return true; }		bool IsIntegratedAssemblerDefault() const override { return true; }
llvm::opt::DerivedArgList *		llvm::opt::DerivedArgList *
TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch,		TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch,
Action::OffloadKind DeviceOffloadKind) const override;		Action::OffloadKind DeviceOffloadKind) const override;
};		};

} // end namespace toolchains		} // end namespace toolchains
} // end namespace driver		} // end namespace driver
} // end namespace clang		} // end namespace clang

#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_AMDGPU_H		#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_AMDGPU_H

	// RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 \| FileCheck -check-prefix=AS_LINK %s			// RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 \| FileCheck -check-prefix=AS_LINK %s
	// AS_LINK: clang{{.*}} "-cc1as"			// AS_LINK: clang{{.*}} "-cc1as"
	// AS_LINK: ld.lld{{.*}} "-shared"			// AS_LINK: ld.lld{{.*}} "-shared"

	// RUN: %clang -### -g -target amdgcn--amdhsa -mcpu=kaveri %s 2>&1 \| FileCheck -check-prefix=DWARF_VER %s			// RUN: %clang -### -g -target amdgcn--amdhsa -mcpu=kaveri %s 2>&1 \| FileCheck -check-prefix=DWARF_VER %s
	// DWARF_VER: "-dwarf-version=5"			// DWARF_VER: "-dwarf-version=2"