This is an archive of the discontinued LLVM Phabricator instance.

[x86/SLH] Clean up helper naming for return instruction handling and remove dead declaration of a call instruction handling helper.
ClosedPublic

Authored by chandlerc on Jul 19 2018, 3:10 PM.

Details

Summary

This moves to the 'harden' terminology that I've been trying to settle
on for returns. It also adds a really detailed comment explaining what
all we're trying to accomplish with return instructions and why.
Hopefully this makes it much more clear what exactly is being
"hardened".

Diff Detail

Event Timeline

chandlerc created this revision.Jul 19 2018, 3:10 PM
echristo accepted this revision.Jul 19 2018, 3:21 PM

LGTM. The comment is particularly helpful, thanks!

This revision is now accepted and ready to land.Jul 19 2018, 3:21 PM
This revision was automatically updated to reflect the committed changes.