Page MenuHomePhabricator

[XRay] Remove scheduling dependency in fork_basic_logging.cc
ClosedPublic

Authored by Maknee on Jul 19 2018, 10:34 AM.

Event Timeline

Maknee created this revision.Jul 19 2018, 10:34 AM
ormris accepted this revision.Jul 19 2018, 11:03 AM
This revision is now accepted and ready to land.Jul 19 2018, 11:03 AM
dberris accepted this revision.Jul 19 2018, 3:32 PM

LGTM -- Thanks @Maknee!

This comment was removed by TWeaver.
Maknee closed this revision.Jul 23 2018, 9:21 AM
Maknee reopened this revision.EditedJul 23 2018, 10:35 AM

@dberris Could you commit this revision? I'm having some trouble trying to commit the revision

Thanks

Never mind. I managed to commit the revision.

This revision is now accepted and ready to land.Jul 23 2018, 10:35 AM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptJul 23 2018, 11:43 AM
Maknee reopened this revision.Jul 23 2018, 12:44 PM

@ormris
@dberris

It seems like I have committed the changes to the wrong directory accidentally -- making the build bot fail.

Would it be possible to revert the commit?

This revision is now accepted and ready to land.Jul 23 2018, 12:44 PM
Maknee updated this revision to Diff 156864.Jul 23 2018, 1:29 PM

Added back changes (were lost from commit)

This revision was automatically updated to reflect the committed changes.