Page MenuHomePhabricator

Maknee (Henry Zhu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 26 2018, 7:33 AM (64 w, 3 d)

Recent Activity

Jul 24 2018

Maknee accepted D49730: Don't filter test-critical calls out of xray data.

Good catch @jmorse

Jul 24 2018, 10:20 AM

Jul 23 2018

Maknee updated the diff for D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.

Added back changes (were lost from commit)

Jul 23 2018, 1:29 PM
Maknee committed rCRT337733: Landed XRay patch (D49559) in incorrect directory. Reverting changes. .
Landed XRay patch (D49559) in incorrect directory. Reverting changes.
Jul 23 2018, 1:07 PM
Maknee committed rL337733: Landed XRay patch (D49559) in incorrect directory. Reverting changes. .
Landed XRay patch (D49559) in incorrect directory. Reverting changes.
Jul 23 2018, 1:07 PM
Maknee reopened D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.

It seems like I have committed the changes to the wrong directory accidentally -- making the build bot fail.

Jul 23 2018, 12:44 PM
Maknee committed rL337724: [XRay] Remove scheduling dependency in fork_basic_logging.cc.
[XRay] Remove scheduling dependency in fork_basic_logging.cc
Jul 23 2018, 11:43 AM
Maknee committed rCRT337724: [XRay] Remove scheduling dependency in fork_basic_logging.cc.
[XRay] Remove scheduling dependency in fork_basic_logging.cc
Jul 23 2018, 11:43 AM
Maknee closed D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.
Jul 23 2018, 11:43 AM
Maknee reopened D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.

@dberris Could you commit this revision? I'm having some trouble trying to commit the revision

Jul 23 2018, 10:35 AM
Maknee closed D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.
Jul 23 2018, 9:21 AM

Jul 19 2018

Maknee added a comment to D49501: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc.

There is an ordering currently (There shouldn't have been)

Jul 19 2018, 10:35 AM
Maknee created D49559: [XRay] Remove scheduling dependency in fork_basic_logging.cc.
Jul 19 2018, 10:34 AM
Maknee added a comment to D49501: Remove scheduling dependency from XRay :: Posix/fork_basic_logging.cc.

Sorry for responding so late -- I noticed that this was happening too.

Jul 19 2018, 8:02 AM

Jul 16 2018

Maknee committed rCRT337176: Test commit.
Test commit
Jul 16 2018, 7:59 AM
Maknee committed rL337176: Test commit.
Test commit
Jul 16 2018, 7:59 AM

Jul 12 2018

Maknee added a comment to D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

LGTM -- Thanks, @Maknee!

One style comment, and I'm happy to land after that.

You might also want to consider applying for commit access if you would like to continue working on parts of XRay moving forward.

https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Jul 12 2018, 10:06 PM
Maknee updated the diff for D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

Fixed one liner if statement to not include curly braces

Jul 12 2018, 10:05 PM
Maknee updated the diff for D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

Changes llvm-xray:

  • convert mode checks for differences in header version numbers when parsing/outputting values (to make sure older traces won't generate errors)
Jul 12 2018, 1:49 PM

Jul 11 2018

Maknee added a comment to D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

Thanks @Maknee -- now if you look in llvm/test/tools/llvm-xray/X86 you'll find some tests for the llvm-xray tool. Also, in the Inputs sub-directory, you'll find sample XRay traces of the old versions. It would be great if you can add version 3 sample binary traces there and add more tests to ensure that we are getting the expected data from the tools handling the newer version(s) of the traces.

Jul 11 2018, 8:09 PM
Maknee updated the diff for D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

Addressed the changes to return statement and curly braces for one liner if statements

Jul 11 2018, 7:36 PM
Maknee updated the diff for D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.

FDR/Basic changes:

  • Updated header version 2 -> 3
Jul 11 2018, 2:08 PM

Jul 10 2018

Maknee created D49153: [XRay][compiler-rt] Add PID field to llvm-xray tool and add PID metadata record entry in FDR mode.
Jul 10 2018, 2:08 PM
Maknee accepted D49025: [XRay] basic mode PID and TID always fetch.

Ready to land

Jul 10 2018, 10:52 AM
Maknee updated the diff for D49025: [XRay] basic mode PID and TID always fetch.

Changed Pid to PId in XRayRecord

Jul 10 2018, 10:50 AM

Jul 9 2018

Maknee updated the diff for D49025: [XRay] basic mode PID and TID always fetch.

Replaced getpid() with internal_getpid(). Removed TID field from TLD and removed references to the TID field.

Jul 9 2018, 10:46 AM
Maknee updated the diff for D49025: [XRay] basic mode PID and TID always fetch.
  1. Updating D49025: [XRay] basic mode PID and TID always fetch
Jul 9 2018, 9:11 AM
Maknee updated the diff for D49025: [XRay] basic mode PID and TID always fetch.
Jul 9 2018, 8:19 AM

Jul 6 2018

Maknee retitled D49025: [XRay] basic mode PID and TID always fetch from XRay basic mode PID and TID always fetch to [XRay] basic mode PID and TID always fetch.
Jul 6 2018, 7:59 AM
Maknee created D49025: [XRay] basic mode PID and TID always fetch.
Jul 6 2018, 7:57 AM