This is an archive of the discontinued LLVM Phabricator instance.

Differential D49506

[ELF] gdb-index: ignore DWARFAddressRange whose SectionIndex=-1
AbandonedPublic

Authored by MaskRay on Jul 18 2018, 1:15 PM.

Details

Reviewers
ruiu
• espindola
Summary

DWARFDataExtractor::getRelocatedValue may set section index to -1

Diff Detail

Revision Contents

PathSize
ELF/
2 lines

Diff 156141

ELF/SyntheticSections.cpp

Show First 20 Lines • Show All 2,316 Lines • ▼ Show 20 LinesreadAddressAreas(DWARFContext &Dwarf, InputSection *Sec) {
uint32_t CuIdx = 0; uint32_t CuIdx = 0;
for (std::unique_ptr<DWARFCompileUnit> &Cu : Dwarf.compile_units()) { for (std::unique_ptr<DWARFCompileUnit> &Cu : Dwarf.compile_units()) {
DWARFAddressRangesVector Ranges; DWARFAddressRangesVector Ranges;
Cu->collectAddressRanges(Ranges); Cu->collectAddressRanges(Ranges);
ArrayRef<InputSectionBase *> Sections = Sec->File->getSections(); ArrayRef<InputSectionBase *> Sections = Sec->File->getSections();
for (DWARFAddressRange &R : Ranges) { for (DWARFAddressRange &R : Ranges) {
if (R.SectionIndex == UINT64_C(-1))
continue;
InputSectionBase *S = Sections[R.SectionIndex]; InputSectionBase *S = Sections[R.SectionIndex];
if (!S || S == &InputSection::Discarded || !S->Live) if (!S || S == &InputSection::Discarded || !S->Live)
continue; continue;
// Range list with zero size has no effect. // Range list with zero size has no effect.
if (R.LowPC == R.HighPC) if (R.LowPC == R.HighPC)
continue; continue;
auto *IS = cast<InputSection>(S); auto *IS = cast<InputSection>(S);
uint64_t Offset = IS->getOffsetInFile(); uint64_t Offset = IS->getOffsetInFile();
▲ Show 20 Lines • Show All 759 Lines • Show Last 20 Lines