Page MenuHomePhabricator

Move pretty stack trace printer into driver.

Authored by JDevlieghere on Jul 16 2018, 7:37 AM.



We used to have a pretty stack trace printer in SystemInitializerCommon. This was disabled on Apple because we didn't want the library to be setting signal handlers, as this was causing issues when loaded into Xcode. However, I think it's useful to have this for the LLDB driver, so I moved it up to use the PrettyStackTraceProgram in the driver's main.

Diff Detail


Event Timeline

JDevlieghere created this revision.Jul 16 2018, 7:37 AM
labath accepted this revision.Jul 16 2018, 7:54 AM

I think this makes perfect sense. Could you also add the same thing to the other binaries in the tools subfolder?

This revision is now accepted and ready to land.Jul 16 2018, 7:54 AM

I've added it to the tools that made sense to me. Let me know if I missed something obvious.

This revision was automatically updated to reflect the committed changes.