This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Increase robustness of tests calling llvm-ar
AbandonedPublic

Authored by chrisjackson on Jul 11 2018, 7:09 AM.

Details

Reviewers
ruiu
Summary

Some lit tests that call llvm-ar use the 'r' flag. If the target archive already
exists and is in a corrupt state, this can cause the test to fail. We have
added 'rm -f archive' calls before the llvm-ar calls to increase the robustness
of the tests.

A similar fix for one test was added in revision r336366.

Diff Detail

Event Timeline

chrisjackson created this revision.Jul 11 2018, 7:09 AM
chrisjackson edited the summary of this revision. (Show Details)
ruiu accepted this revision.Jul 11 2018, 9:54 AM

LGTM

This revision is now accepted and ready to land.Jul 11 2018, 9:54 AM
chrisjackson abandoned this revision.Aug 6 2021, 6:28 AM