[analyzer] Provide a symmetric method for generating a PathDiagnosticLocation from Decl

[george.karpenkov]

Summary

Useful for generic code working with both declarations and statements.

[NoQ]

You might need to annotate the unused parameter to avoid a compiler warning.

clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h

static PathDiagnosticLocation create(const Decl *D,
                                        const SourceManager &SM) {
     return PathDiagnosticLocation(D, SM);
   }
 
   /// Create a location for the beginning of the declaration.
   static PathDiagnosticLocation createBegin(const Decl *D,
                                             const SourceManager &SM);
 
+  /// Create a location for the beginning of the declaration.
+  /// The third argument is ignored, useful for generic treatment
+  /// of statements and declarations.
+  static PathDiagnosticLocation
+  createBegin(const Decl *D, const SourceManager &SM,
+              const LocationOrAnalysisDeclContext LAC) {
+    return createBegin(D, SM);
+  }
+
   /// Create a location for the beginning of the statement.
   static PathDiagnosticLocation createBegin(const Stmt *S,
                                             const SourceManager &SM,
                                             const LocationOrAnalysisDeclContext LAC);
 
   /// Create a location for the end of the statement.
   ///
   /// If the statement is a CompoundStatement, the location will point to the