This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Declare noop_coroutine() with _LIBCPP_INLINE_VISIBILITY
ClosedPublic

Authored by ldionne on Jul 10 2018, 9:32 AM.

Details

Summary

It was defined with the right visibility, but declared without any visibility.
This function was left out of a prior revision that did the same to several
functions in <compare> (r336665) because the compiler I used didn't support
coroutines. This reinforces the need for automated checks -- there might
still be several cases of this throughout the library.

Diff Detail

Repository
rL LLVM

Event Timeline

ldionne created this revision.Jul 10 2018, 9:32 AM
EricWF accepted this revision.Jul 10 2018, 10:19 AM
This revision is now accepted and ready to land.Jul 10 2018, 10:19 AM
This revision was automatically updated to reflect the committed changes.