This is an archive of the discontinued LLVM Phabricator instance.

Differential D49143

Fix a typo/regression in r335495.
ClosedPublic

Authored by bsdjhb on Jul 10 2018, 9:10 AM.

Details

Reviewers
arichardson
atanasyan
Commits
rG8a211cc64e78: Fix a typo/regression in r335495.
rL336710: Fix a typo/regression in r335495.
rC336710: Fix a typo/regression in r335495.
Summary

Use getTriple.isMIPS64() to detect 64-bit MIPS ABIs in
FreeBSD::getSupportedSanitizers() instead of getTriple.isMIPS32().

Diff Detail

Repository
rC Clang

Event Timeline

bsdjhb created this revision.Jul 10 2018, 9:10 AM
Herald added subscribers: atanasyan, krytarowski, sdardis, emaste. · View Herald TranscriptJul 10 2018, 9:10 AM
Harbormaster completed remote builds in B20209: Diff 154825.Jul 10 2018, 9:10 AM
atanasyan added a comment.Jul 10 2018, 9:16 AM

It would be nice to have a test for this regression.

bsdjhb added a comment.Jul 10 2018, 9:40 AM

AFAICT, I don't see a way to ask clang "which sanitizers are supported by this target". Hmm, the CHECK-SANL-MIPS test in tests/Driver/fsanitize.c seems like the closest match.

bsdjhb updated this revision to Diff 154840.Jul 10 2018, 10:36 AM

Add tests.

Harbormaster completed remote builds in B20215: Diff 154840.Jul 10 2018, 10:36 AM
atanasyan accepted this revision.Jul 10 2018, 10:37 AM

LGTM

This revision is now accepted and ready to land.Jul 10 2018, 10:37 AM
Closed by commit rC336710: Fix a typo/regression in r335495. (authored by jhb). · Explain WhyJul 10 2018, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Driver/
ToolChains/
2 lines
test/
Driver/
6 lines

Diff 154845

lib/Driver/ToolChains/FreeBSD.cpp

Show First 20 Lines • Show All 402 Lines • ▼ Show 20 Lines
bool FreeBSD::HasNativeLLVMSupport() const { return true; } bool FreeBSD::HasNativeLLVMSupport() const { return true; }
bool FreeBSD::isPIEDefault() const { return getSanitizerArgs().requiresPIE(); } bool FreeBSD::isPIEDefault() const { return getSanitizerArgs().requiresPIE(); }
SanitizerMask FreeBSD::getSupportedSanitizers() const { SanitizerMask FreeBSD::getSupportedSanitizers() const {
const bool IsX86 = getTriple().getArch() == llvm::Triple::x86; const bool IsX86 = getTriple().getArch() == llvm::Triple::x86;
const bool IsX86_64 = getTriple().getArch() == llvm::Triple::x86_64; const bool IsX86_64 = getTriple().getArch() == llvm::Triple::x86_64;
const bool IsMIPS64 = getTriple().isMIPS32(); const bool IsMIPS64 = getTriple().isMIPS64();
SanitizerMask Res = ToolChain::getSupportedSanitizers(); SanitizerMask Res = ToolChain::getSupportedSanitizers();
Res |= SanitizerKind::Address; Res |= SanitizerKind::Address;
Res |= SanitizerKind::Vptr; Res |= SanitizerKind::Vptr;
if (IsX86_64 || IsMIPS64) { if (IsX86_64 || IsMIPS64) {
Res |= SanitizerKind::Leak; Res |= SanitizerKind::Leak;
Res |= SanitizerKind::Thread; Res |= SanitizerKind::Thread;
} }
if (IsX86 || IsX86_64) { if (IsX86 || IsX86_64) {
Show All 9 Lines

test/Driver/fsanitize.c

Show First 20 Lines • Show All 310 Lines • ▼ Show 20 Lines
// CHECK-SANL-THUMBEB: "-fsanitize=leak" // CHECK-SANL-THUMBEB: "-fsanitize=leak"
// RUN: %clang -target thumbeb-linux -fsanitize=address,leak -fno-sanitize=address %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANA-SANL-NO-SANA-THUMBEB // RUN: %clang -target thumbeb-linux -fsanitize=address,leak -fno-sanitize=address %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANA-SANL-NO-SANA-THUMBEB
// CHECK-SANA-SANL-NO-SANA-THUMBEB: "-fsanitize=leak" // CHECK-SANA-SANL-NO-SANA-THUMBEB: "-fsanitize=leak"
// RUN: %clang -target mips-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-MIPS // RUN: %clang -target mips-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-MIPS
// CHECK-SANL-MIPS: unsupported option '-fsanitize=leak' for target 'mips-unknown-linux' // CHECK-SANL-MIPS: unsupported option '-fsanitize=leak' for target 'mips-unknown-linux'
// RUN: %clang -target mips-unknown-freebsd -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-MIPS-FREEBSD
// CHECK-SANL-MIPS-FREEBSD: unsupported option '-fsanitize=leak' for target 'mips-unknown-freebsd'
// RUN: %clang -target mips64-unknown-freebsd -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-MIPS64-FREEBSD
// CHECK-SANL-MIPS64-FREEBSD: "-fsanitize=leak"
// RUN: %clang -target powerpc64-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-PPC64 // RUN: %clang -target powerpc64-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-PPC64
// RUN: %clang -target powerpc64le-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-PPC64 // RUN: %clang -target powerpc64le-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-PPC64
// CHECK-SANL-PPC64: "-fsanitize=leak" // CHECK-SANL-PPC64: "-fsanitize=leak"
// RUN: %clang -target powerpc-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-PPC // RUN: %clang -target powerpc-unknown-linux -fsanitize=leak %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-SANL-PPC
// CHECK-SANL-PPC: unsupported option '-fsanitize=leak' for target 'powerpc-unknown-linux' // CHECK-SANL-PPC: unsupported option '-fsanitize=leak' for target 'powerpc-unknown-linux'
// RUN: %clang -target x86_64-linux-gnu -fsanitize=memory %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN // RUN: %clang -target x86_64-linux-gnu -fsanitize=memory %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN
// CHECK-MSAN: "-fno-assume-sane-operator-new" // CHECK-MSAN: "-fno-assume-sane-operator-new"
▲ Show 20 Lines • Show All 379 Lines • Show Last 20 Lines