Page MenuHomePhabricator

Fix a typo/regression in r335495.
ClosedPublic

Authored by bsdjhb on Jul 10 2018, 9:10 AM.

Details

Summary

Use getTriple.isMIPS64() to detect 64-bit MIPS ABIs in
FreeBSD::getSupportedSanitizers() instead of getTriple.isMIPS32().

Diff Detail

Repository
rC Clang

Event Timeline

bsdjhb created this revision.Jul 10 2018, 9:10 AM

It would be nice to have a test for this regression.

AFAICT, I don't see a way to ask clang "which sanitizers are supported by this target". Hmm, the CHECK-SANL-MIPS test in tests/Driver/fsanitize.c seems like the closest match.

bsdjhb updated this revision to Diff 154840.Jul 10 2018, 10:36 AM

Add tests.

This revision is now accepted and ready to land.Jul 10 2018, 10:37 AM
This revision was automatically updated to reflect the committed changes.