[analyzer] Move InnerPointerChecker out of alpha

[xazax.hun]

Don't you need to edit the tests as well?

[rnkovacs]

Fix test run line.

[george.karpenkov]

@rnkovacs Do you have evaluation statistics handy for this checker? How many bugs it finds, on which projects? How many of those are real bugs?

[rnkovacs]

In D49058#1159533, @george.karpenkov wrote:

@rnkovacs Do you have evaluation statistics handy for this checker? How many bugs it finds, on which projects? How many of those are real bugs?

In its present form, it does not produce many reports, so it might be worth waiting for patches like D49360 and D49361 that add more functionality.
A recent run on LibreOffice showed one report by this checker, and it seems like a real bug (in an external package called GPGME).
Can be seen here, or if it does not work, line 135 here (quite a one-liner).

[rnkovacs]

Two more reports on Ceph that seem to be true positives (no other reports from this checker):

1. Here (or if it does not work, the bug is on L130 here).
2. Here (or L363 and L373 here).

[george.karpenkov]

@rnkovacs Personally I'm fine with moving it out of alpha then.
If all the reports you have seen so far are true positives, then it's *amazing*.
I would even go as far as filing bugs on the projects in question (as a by-product, it generates visibility for you, your checker, and the analyzer) but of course it's up to you.

[rnkovacs]

Rebase.

[NoQ]

Ok, cool! Let's get this done.

include/clang/StaticAnalyzer/Checkers/Checkers.td

 } // end "core.uninitialized"
 
 //===----------------------------------------------------------------------===//
 // C++ checkers.
 //===----------------------------------------------------------------------===//
 
 let ParentPackage = Cplusplus in {
 
+def InnerPointerChecker : Checker<"InnerPointer">,
+  HelpText<"Check for inner pointers of C++ containers used after re/deallocation">,
+  DescFile<"InnerPointerChecker.cpp">;
+
 def NewDeleteChecker : Checker<"NewDelete">,
   HelpText<"Check for double-free and use-after-free problems. Traces memory managed by new/delete.">,
   DescFile<"MallocChecker.cpp">;
 
 def NewDeleteLeaksChecker : Checker<"NewDeleteLeaks">,
   HelpText<"Check for memory leaks. Traces memory managed by new/delete.">,
   DescFile<"MallocChecker.cpp">;
 

 
 let ParentPackage = CplusplusAlpha in {
 
 def DeleteWithNonVirtualDtorChecker : Checker<"DeleteWithNonVirtualDtor">,
   HelpText<"Reports destructions of polymorphic objects with a non-virtual "
            "destructor in their base class">,
   DescFile<"DeleteWithNonVirtualDtorChecker.cpp">;
 
-def InnerPointerChecker : Checker<"InnerPointer">,
-  HelpText<"Check for inner pointers of C++ containers used after re/deallocation">,
-  DescFile<"InnerPointerChecker.cpp">;
-
 def IteratorRangeChecker : Checker<"IteratorRange">,
   HelpText<"Check for iterators used outside their valid ranges">,
   DescFile<"IteratorChecker.cpp">;
 
 def MisusedMovedObjectChecker: Checker<"MisusedMovedObject">,
      HelpText<"Method calls on a moved-from object and copying a moved-from "
               "object will be reported">,
      DescFile<"MisusedMovedObjectChecker.cpp">;

test/Analysis/inner-pointer.cpp

-//RUN: %clang_analyze_cc1 -analyzer-checker=alpha.cplusplus.InnerPointer %s -analyzer-output=text -verify
+//RUN: %clang_analyze_cc1 -analyzer-checker=cplusplus.InnerPointer %s -analyzer-output=text -verify
 
 namespace std {
 
 typedef int size_type;
 
 template <typename CharT>
 class basic_string {
 public: