Page MenuHomePhabricator

[VPlan] Add VPlanTestBase.h with helper class to build VPlan for tests.
ClosedPublic

Authored by fhahn on Jul 6 2018, 9:42 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

fhahn created this revision.Jul 6 2018, 9:42 AM
dcaballe accepted this revision.Jul 6 2018, 12:11 PM

Good idea! Thanks! LGTM. Just some minor comments.

unittests/Transforms/Vectorize/VPlanHCFGTest.cpp
93 ↗(On Diff #154427)

Shouldn't we keep VPlanHCFGTest name? Or, is this renaming needed?

unittests/Transforms/Vectorize/VPlanTestBase.h
9 ↗(On Diff #154427)

Add small comment about the purpose of the file?

46 ↗(On Diff #154427)

I had to differentiate between building 'plain' CFG and building H-CFG for testing in D48818. It would be great I you could align this code a bit with those needs. I'll introduce the necessary changes once we have this code in.

This revision is now accepted and ready to land.Jul 6 2018, 12:11 PM
This revision was automatically updated to reflect the committed changes.