This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Define __STDC_FORMAT_MACROS in callback.h
ClosedPublic

Authored by kkwli0 on Jul 5 2018, 11:22 AM.

Download Raw Diff

Details

Reviewers

protze.joachim
Hahnfeld
AndreyChurbanov
ABataev

Commits

rGb1711b28f7a8: Define the __STDC_FORMAT_MACROS to avoid test failure on some platforms.
rOMP336438: Define the __STDC_FORMAT_MACROS to avoid test failure on some platforms.
rL336438: Define the __STDC_FORMAT_MACROS to avoid test failure on some platforms.

Summary

The following test cases fail due to undefined PRIu64.

ompt/misc/api_calls_from_other_thread.cpp
ompt/misc/interoperability.cpp

# command stderr:
In file included from /gsa/tlbgsa-h1/00/kli/clang-latest/llvm/projects/openmp/runtime/test/ompt/misc/interoperability.cpp:8:
/gsa/tlbgsa/home/k/l/kli/clang-latest/llvm/projects/openmp/runtime/test/ompt/callback.h:1:9: warning: '_BSD_SOURCE' macro redefined [-Wmacro-redefined]
#define _BSD_SOURCE
        ^
/usr/include/features.h:176:10: note: previous definition is here
# define _BSD_SOURCE    1
         ^
In file included from /gsa/tlbgsa-h1/00/kli/clang-latest/llvm/projects/openmp/runtime/test/ompt/misc/interoperability.cpp:8:
/gsa/tlbgsa/home/k/l/kli/clang-latest/llvm/projects/openmp/runtime/test/ompt/callback.h:85:16: error: expected ')'
    printf("%" PRIu64 ": task level %d: parallel_id=%" PRIu64
               ^
/gsa/tlbgsa/home/k/l/kli/clang-latest/llvm/projects/openmp/runtime/test/ompt/callback.h:85:11: note: to match this '('
    printf("%" PRIu64 ": task level %d: parallel_id=%" PRIu64
          ^
/gsa/tlbgsa/home/k/l/kli/clang-latest/llvm/projects/openmp/runtime/test/ompt/callback.h:198:18: error: expected ')'
      printf("%" PRIu64 ": ompt_event_wait_lock: wait_id=%" PRIu64 ", hint=%" PRIu32 ", impl=%" PRIu32 ", codeptr_ra=%p \n", ompt_get_thread_data()->value, wait_id, hint, impl, codeptr_ra);
                 ^
...

Diff Detail

Repository: rL LLVM

Event Timeline

kkwli0 created this revision.Jul 5 2018, 11:22 AM

kkwli0 created this object with visibility "Restricted Project (Project)".

Herald added a subscriber: guansong. · View Herald TranscriptJul 5 2018, 11:22 AM

kkwli0 edited the summary of this revision. (Show Details)Jul 5 2018, 11:23 AM

kkwli0 changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Jul 5 2018, 11:26 AM

Lgtm

This revision is now accepted and ready to land.Jul 5 2018, 11:57 AM

Closed by commit rL336438: Define the __STDC_FORMAT_MACROS to avoid test failure on some platforms. (authored by kli). · Explain WhyJul 6 2018, 7:21 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptJul 6 2018, 7:21 AM

Revision Contents

Path

Size

openmp/

trunk/

runtime/

test/

ompt/

callback.h

5 lines

Diff 154403

openmp/trunk/runtime/test/ompt/callback.h

				#ifndef _BSD_SOURCE
	#define _BSD_SOURCE			#define _BSD_SOURCE
				#endif
	#define _DEFAULT_SOURCE			#define _DEFAULT_SOURCE
	#include <stdio.h>			#include <stdio.h>
				#ifndef __STDC_FORMAT_MACROS
				#define __STDC_FORMAT_MACROS
				#endif
	#include <inttypes.h>			#include <inttypes.h>
	#include <omp.h>			#include <omp.h>
	#include <ompt.h>			#include <ompt.h>
	#include "ompt-signal.h"			#include "ompt-signal.h"

	// Used to detect architecture			// Used to detect architecture
	#include "../../src/kmp_platform.h"			#include "../../src/kmp_platform.h"

	▲ Show 20 Lines • Show All 745 Lines • Show Last 20 Lines