This is an archive of the discontinued LLVM Phabricator instance.

Differential D48982

[mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options
ClosedPublic

Authored by vstefanovic on Jul 5 2018, 10:49 AM.

Details

Reviewers
atanasyan
Commits
rG00869f32149e: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options
rL336798: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options
rC336798: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options
Summary

'-mvirt'/'-mno-virt' enables/disables Virtualization ASE.
'-mginv'/'-mno-ginv' enables/disables GINV (Global Invalidate) ASE.

Diff Detail

Repository
rC Clang

Event Timeline

vstefanovic created this revision.Jul 5 2018, 10:49 AM
Herald added subscribers: cfe-commits, arichardson, sdardis. · View Herald TranscriptJul 5 2018, 10:49 AM
atanasyan accepted this revision.Jul 10 2018, 9:58 AM

LGTM

This revision is now accepted and ready to land.Jul 10 2018, 9:58 AM
Closed by commit rC336798: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options (authored by vstefanovic). · Explain WhyJul 11 2018, 5:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
clang/
Driver/
4 lines
lib/
Driver/
ToolChains/
Arch/
4 lines
test/
Driver/
24 lines

Diff 154267

include/clang/Driver/Options.td

Show First 20 Lines • Show All 2,208 Lines • ▼ Show 20 Lines
def mnan_EQ : Joined<["-"], "mnan=">, Group<m_mips_Features_Group>; def mnan_EQ : Joined<["-"], "mnan=">, Group<m_mips_Features_Group>;
def mabs_EQ : Joined<["-"], "mabs=">, Group<m_mips_Features_Group>; def mabs_EQ : Joined<["-"], "mabs=">, Group<m_mips_Features_Group>;
def mabicalls : Flag<["-"], "mabicalls">, Group<m_mips_Features_Group>, def mabicalls : Flag<["-"], "mabicalls">, Group<m_mips_Features_Group>,
HelpText<"Enable SVR4-style position-independent code (Mips only)">; HelpText<"Enable SVR4-style position-independent code (Mips only)">;
def mno_abicalls : Flag<["-"], "mno-abicalls">, Group<m_mips_Features_Group>, def mno_abicalls : Flag<["-"], "mno-abicalls">, Group<m_mips_Features_Group>,
HelpText<"Disable SVR4-style position-independent code (Mips only)">; HelpText<"Disable SVR4-style position-independent code (Mips only)">;
def mno_crc : Flag<["-"], "mno-crc">, Group<m_mips_Features_Group>, def mno_crc : Flag<["-"], "mno-crc">, Group<m_mips_Features_Group>,
HelpText<"Disallow use of CRC instructions (Mips only)">; HelpText<"Disallow use of CRC instructions (Mips only)">;
def mvirt : Flag<["-"], "mvirt">, Group<m_mips_Features_Group>;
def mno_virt : Flag<["-"], "mno-virt">, Group<m_mips_Features_Group>;
def mginv : Flag<["-"], "mginv">, Group<m_mips_Features_Group>;
def mno_ginv : Flag<["-"], "mno-ginv">, Group<m_mips_Features_Group>;
def mips1 : Flag<["-"], "mips1">, def mips1 : Flag<["-"], "mips1">,
Alias<march_EQ>, AliasArgs<["mips1"]>, Group<m_mips_Features_Group>, Alias<march_EQ>, AliasArgs<["mips1"]>, Group<m_mips_Features_Group>,
HelpText<"Equivalent to -march=mips1">, Flags<[HelpHidden]>; HelpText<"Equivalent to -march=mips1">, Flags<[HelpHidden]>;
def mips2 : Flag<["-"], "mips2">, def mips2 : Flag<["-"], "mips2">,
Alias<march_EQ>, AliasArgs<["mips2"]>, Group<m_mips_Features_Group>, Alias<march_EQ>, AliasArgs<["mips2"]>, Group<m_mips_Features_Group>,
HelpText<"Equivalent to -march=mips2">, Flags<[HelpHidden]>; HelpText<"Equivalent to -march=mips2">, Flags<[HelpHidden]>;
def mips3 : Flag<["-"], "mips3">, def mips3 : Flag<["-"], "mips3">,
Alias<march_EQ>, AliasArgs<["mips3"]>, Group<m_mips_Features_Group>, Alias<march_EQ>, AliasArgs<["mips3"]>, Group<m_mips_Features_Group>,
▲ Show 20 Lines • Show All 770 Lines • Show Last 20 Lines

lib/Driver/ToolChains/Arch/Mips.cpp

Show First 20 Lines • Show All 346 Lines • ▼ Show 20 Linesvoid mips::getMIPSTargetFeatures(const Driver &D, const llvm::Triple &Triple,
AddTargetFeature(Args, Features, options::OPT_mno_odd_spreg, AddTargetFeature(Args, Features, options::OPT_mno_odd_spreg,
options::OPT_modd_spreg, "nooddspreg"); options::OPT_modd_spreg, "nooddspreg");
AddTargetFeature(Args, Features, options::OPT_mno_madd4, options::OPT_mmadd4, AddTargetFeature(Args, Features, options::OPT_mno_madd4, options::OPT_mmadd4,
"nomadd4"); "nomadd4");
AddTargetFeature(Args, Features, options::OPT_mmt, options::OPT_mno_mt, "mt"); AddTargetFeature(Args, Features, options::OPT_mmt, options::OPT_mno_mt, "mt");
AddTargetFeature(Args, Features, options::OPT_mcrc, options::OPT_mno_crc, AddTargetFeature(Args, Features, options::OPT_mcrc, options::OPT_mno_crc,
"crc"); "crc");
AddTargetFeature(Args, Features, options::OPT_mvirt, options::OPT_mno_virt,
"virt");
AddTargetFeature(Args, Features, options::OPT_mginv, options::OPT_mno_ginv,
"ginv");
if (Arg *A = Args.getLastArg(options::OPT_mindirect_jump_EQ)) { if (Arg *A = Args.getLastArg(options::OPT_mindirect_jump_EQ)) {
StringRef Val = StringRef(A->getValue()); StringRef Val = StringRef(A->getValue());
if (Val == "hazard") { if (Val == "hazard") {
Arg *B = Arg *B =
Args.getLastArg(options::OPT_mmicromips, options::OPT_mno_micromips); Args.getLastArg(options::OPT_mmicromips, options::OPT_mno_micromips);
Arg *C = Args.getLastArg(options::OPT_mips16, options::OPT_mno_mips16); Arg *C = Args.getLastArg(options::OPT_mips16, options::OPT_mno_mips16);
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines

test/Driver/mips-features.c

Show First 20 Lines • Show All 414 Lines • ▼ Show 20 Lines
// RUN: | FileCheck --check-prefix=CHECK-CRC %s // RUN: | FileCheck --check-prefix=CHECK-CRC %s
// CHECK-CRC: "-target-feature" "+crc" // CHECK-CRC: "-target-feature" "+crc"
// //
// -mno-crc // -mno-crc
// RUN: %clang -target mips-unknown-linux-gnu -### -c %s \ // RUN: %clang -target mips-unknown-linux-gnu -### -c %s \
// RUN: -mcrc -mno-crc 2>&1 \ // RUN: -mcrc -mno-crc 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NO-CRC %s // RUN: | FileCheck --check-prefix=CHECK-NO-CRC %s
// CHECK-NO-CRC: "-target-feature" "-crc" // CHECK-NO-CRC: "-target-feature" "-crc"
//
// -mvirt
// RUN: %clang -target mips-unknown-linux-gnu -### -c %s \
// RUN: -mno-virt -mvirt 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-VIRT %s
// CHECK-VIRT: "-target-feature" "+virt"
//
// -mno-virt
// RUN: %clang -target mips-unknown-linux-gnu -### -c %s \
// RUN: -mvirt -mno-virt 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NO-VIRT %s
// CHECK-NO-VIRT: "-target-feature" "-virt"
//
// -mginv
// RUN: %clang -target mips-unknown-linux-gnu -### -c %s \
// RUN: -mno-ginv -mginv 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-GINV %s
// CHECK-GINV: "-target-feature" "+ginv"
//
// -mno-ginv
// RUN: %clang -target mips-unknown-linux-gnu -### -c %s \
// RUN: -mginv -mno-ginv 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-NO-GINV %s
// CHECK-NO-GINV: "-target-feature" "-ginv"