[Polly-ACC] Add isl_space.h to gpu_tree.c

[alaindenzler]

Summary

This patch adds <isl_space.h> to gpu_tree.c. This prevents a segfault when allocating a new isl_space in the function create_sync_domain(), as the compiler now knows that the return type is a pointer instead of assuming the function returns an int.

Inspired by Tobias Grosser & Siddhart, initially discovered by Philip Pfaffe.

[philip.pfaffe]

Thanks for fixing this!

This can manifest itself as a bug only because we're building with C89, which doesn't even warn about the missing declaration. Does it make sense to also raise the version? That should be a separate change though.

[grosser]

Yes, raise we should raise the version. Also, please add a propoer commit message explaining what the underlying error was here. We should also make sure that this bug has been fixed in the latest ppcg, such that we do not re-import it again.

[alaindenzler]

I checked the latest ppcg source and the header is also included there. Maybe consider updating to the latest ppcg?

lib/External/ppcg/gpu_tree.c

 
 #include <isl/set.h>
 #include <isl/union_set.h>
+#include <isl/space.h>
 
 #include "gpu_tree.h"