Page MenuHomePhabricator

[Polly-ACC] Add isl_space.h to gpu_tree.c
ClosedPublic

Authored by alaindenzler on Jul 3 2018, 8:00 AM.

Details

Summary

This patch adds <isl_space.h> to gpu_tree.c. This prevents a segfault when allocating a new isl_space in the function create_sync_domain(), as the compiler now knows that the return type is a pointer instead of assuming the function returns an int.

Inspired by Tobias Grosser & Siddhart, initially discovered by Philip Pfaffe.

Diff Detail

Repository
rL LLVM

Event Timeline

alaindenzler created this revision.Jul 3 2018, 8:00 AM

Thanks for fixing this!

This can manifest itself as a bug only because we're building with C89, which doesn't even warn about the missing declaration. Does it make sense to also raise the version? That should be a separate change though.

Yes, raise we should raise the version. Also, please add a propoer commit message explaining what the underlying error was here. We should also make sure that this bug has been fixed in the latest ppcg, such that we do not re-import it again.

alaindenzler edited the summary of this revision. (Show Details)Jul 4 2018, 12:02 AM

I checked the latest ppcg source and the header is also included there. Maybe consider updating to the latest ppcg?

bollu accepted this revision.Jul 4 2018, 2:12 AM
This revision is now accepted and ready to land.Jul 4 2018, 2:12 AM
This revision was automatically updated to reflect the committed changes.