Details
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 19867 Build 19867: arc lint + arc unit
Event Timeline
test/CodeGen/WebAssembly/negative-base-reg.ll | ||
---|---|---|
13–14 | ah, what probably happens is that this is followed by a "get_local 0" now, which this test ignores. Maybe make it into 2 CHECK-NEXT instead? | |
13–14 | I meant "set_local 0, $pop" | |
test/CodeGen/WebAssembly/offset-fastisel.ll | ||
19–23 | same here, makes these CHECK-NEXT to ensure we're not missing things. |
- feedback
test/CodeGen/WebAssembly/offset-fastisel.ll | ||
---|---|---|
19–23 | But don't the register names mean that even if there are instructions inbetween we are still OK? Maybe with the change you are proposing we will require more NEXTs? but i'm not sure if I should add them here are part of this change. |
test/CodeGen/WebAssembly/offset-fastisel.ll | ||
---|---|---|
19–23 | Yes, fine either way, as I'll have to go thru these anyway. |
ah, what probably happens is that this is followed by a "get_local 0" now, which this test ignores. Maybe make it into 2 CHECK-NEXT instead?