Page MenuHomePhabricator

Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors
AbandonedPublic

Authored by pirama on Jun 28 2018, 2:32 PM.

Details

Summary

This function is passed as the at_exit parameter to
libcpp_tls_create. This parameter is marked with the
_LIBCPP_TLS_DESTRUCTOR_CC attribute. The macro is empty for pthread,
and set to stdcall for other threading models. stdcall is in turn
emptry for most cases. That's likely why this doesn't fail now.

The one exception is Windows on i686 with the Win32 threading API, where
the stdcall calling convention is used.

Event Timeline

pirama created this revision.Jun 28 2018, 2:32 PM
pirama abandoned this revision.Sep 21 2018, 12:20 AM

This file is not built for WIN32.